Compare commits
6
Commits
2ebaee8d03
..
v0.3.1
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
4ebea7d023 | ||
|
|
711dc46e5e | ||
|
|
039598855c | ||
|
|
d45ba712ce | ||
|
|
4d658004ae | ||
|
|
3329ff3088 |
@@ -7,7 +7,7 @@ import (
|
|||||||
"os"
|
"os"
|
||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
chassisauth "gitea.d-ma.be/mathias/mcp-chassis/auth"
|
chassisauth "git.d-ma.be/mathias/mcp-chassis/auth"
|
||||||
|
|
||||||
"gitea.d-ma.be/mathias/gitea-mcp/internal/allowlist"
|
"gitea.d-ma.be/mathias/gitea-mcp/internal/allowlist"
|
||||||
"gitea.d-ma.be/mathias/gitea-mcp/internal/auth"
|
"gitea.d-ma.be/mathias/gitea-mcp/internal/auth"
|
||||||
|
|||||||
@@ -3,13 +3,12 @@ module gitea.d-ma.be/mathias/gitea-mcp
|
|||||||
go 1.26.2
|
go 1.26.2
|
||||||
|
|
||||||
require (
|
require (
|
||||||
|
git.d-ma.be/mathias/mcp-chassis v0.2.0
|
||||||
github.com/hashicorp/golang-lru/v2 v2.0.7
|
github.com/hashicorp/golang-lru/v2 v2.0.7
|
||||||
github.com/lestrrat-go/jwx/v2 v2.1.6
|
|
||||||
github.com/stretchr/testify v1.11.1
|
github.com/stretchr/testify v1.11.1
|
||||||
)
|
)
|
||||||
|
|
||||||
require (
|
require (
|
||||||
gitea.d-ma.be/mathias/mcp-chassis v0.1.0 // indirect
|
|
||||||
github.com/davecgh/go-spew v1.1.1 // indirect
|
github.com/davecgh/go-spew v1.1.1 // indirect
|
||||||
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.0 // indirect
|
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.0 // indirect
|
||||||
github.com/goccy/go-json v0.10.3 // indirect
|
github.com/goccy/go-json v0.10.3 // indirect
|
||||||
@@ -17,6 +16,7 @@ require (
|
|||||||
github.com/lestrrat-go/httpcc v1.0.1 // indirect
|
github.com/lestrrat-go/httpcc v1.0.1 // indirect
|
||||||
github.com/lestrrat-go/httprc v1.0.6 // indirect
|
github.com/lestrrat-go/httprc v1.0.6 // indirect
|
||||||
github.com/lestrrat-go/iter v1.0.2 // indirect
|
github.com/lestrrat-go/iter v1.0.2 // indirect
|
||||||
|
github.com/lestrrat-go/jwx/v2 v2.1.6 // indirect
|
||||||
github.com/lestrrat-go/option v1.0.1 // indirect
|
github.com/lestrrat-go/option v1.0.1 // indirect
|
||||||
github.com/pmezard/go-difflib v1.0.0 // indirect
|
github.com/pmezard/go-difflib v1.0.0 // indirect
|
||||||
github.com/segmentio/asm v1.2.0 // indirect
|
github.com/segmentio/asm v1.2.0 // indirect
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
gitea.d-ma.be/mathias/mcp-chassis v0.1.0 h1:8RXO34+n7Vu8HnUMagars6fc4oemqRpMu7MVtjaj4qY=
|
git.d-ma.be/mathias/mcp-chassis v0.2.0 h1:6fLmb7xqRa2nNVWsHaUbbfbArgDXJw/gDhb09clBIjo=
|
||||||
gitea.d-ma.be/mathias/mcp-chassis v0.1.0/go.mod h1:ajbLlwr2L7FAN3TBU39KucZkKJM02wTbKbDKDEW2YvE=
|
git.d-ma.be/mathias/mcp-chassis v0.2.0/go.mod h1:Ks7EK2UnGAN0H3rJjKUxUagX8/ZBdtLrOlcUbv0RwH8=
|
||||||
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
|
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
|
||||||
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
|
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
|
||||||
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
|
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
|
||||||
|
|||||||
@@ -6,7 +6,6 @@ import (
|
|||||||
"fmt"
|
"fmt"
|
||||||
"net/url"
|
"net/url"
|
||||||
"strconv"
|
"strconv"
|
||||||
"strings"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
// DispatchWorkflowArgs is the request body for a workflow_dispatch trigger.
|
// DispatchWorkflowArgs is the request body for a workflow_dispatch trigger.
|
||||||
@@ -15,42 +14,26 @@ type DispatchWorkflowArgs struct {
|
|||||||
Inputs map[string]any `json:"inputs,omitempty"`
|
Inputs map[string]any `json:"inputs,omitempty"`
|
||||||
}
|
}
|
||||||
|
|
||||||
// WorkflowRunTrigger holds the run ID extracted from the Location header.
|
// DispatchWorkflow triggers a workflow_dispatch event. Gitea returns 204 No
|
||||||
type WorkflowRunTrigger struct {
|
// Content with NO Location header, so the response carries no run ID — callers
|
||||||
RunID int64
|
// resolve the new run separately via ListWorkflowRuns. Returns nil on success.
|
||||||
}
|
func (c *Client) DispatchWorkflow(ctx context.Context, owner, repo, workflow string, args DispatchWorkflowArgs) error {
|
||||||
|
|
||||||
// DispatchWorkflow triggers a workflow_dispatch event and returns the new run ID.
|
|
||||||
func (c *Client) DispatchWorkflow(ctx context.Context, owner, repo, workflow string, args DispatchWorkflowArgs) (*WorkflowRunTrigger, error) {
|
|
||||||
p := fmt.Sprintf("/api/v1/repos/%s/%s/actions/workflows/%s/dispatches", owner, repo, workflow)
|
p := fmt.Sprintf("/api/v1/repos/%s/%s/actions/workflows/%s/dispatches", owner, repo, workflow)
|
||||||
payload, err := json.Marshal(args)
|
payload, err := json.Marshal(args)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return err
|
||||||
}
|
}
|
||||||
resp, err := c.doRaw(ctx, "POST", p, payload)
|
resp, err := c.doRaw(ctx, "POST", p, payload)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return err
|
||||||
}
|
}
|
||||||
if resp.Status != 204 {
|
if resp.Status != 204 {
|
||||||
if mapErr := MapStatus(resp.Status, resp.Body); mapErr != nil {
|
if mapErr := MapStatus(resp.Status, resp.Body); mapErr != nil {
|
||||||
return nil, mapErr
|
return mapErr
|
||||||
}
|
}
|
||||||
return nil, fmt.Errorf("unexpected status %d", resp.Status)
|
return fmt.Errorf("unexpected status %d", resp.Status)
|
||||||
}
|
}
|
||||||
location := resp.Headers.Get("Location")
|
return nil
|
||||||
if location == "" {
|
|
||||||
return nil, fmt.Errorf("missing Location header in dispatch response")
|
|
||||||
}
|
|
||||||
// Location is e.g. "/api/v1/repos/o/r/actions/runs/123" — take the last segment.
|
|
||||||
parts := strings.Split(strings.TrimRight(location, "/"), "/")
|
|
||||||
if len(parts) == 0 {
|
|
||||||
return nil, fmt.Errorf("malformed Location: %s", location)
|
|
||||||
}
|
|
||||||
runID, err := strconv.ParseInt(parts[len(parts)-1], 10, 64)
|
|
||||||
if err != nil {
|
|
||||||
return nil, fmt.Errorf("parse run id from %q: %w", location, err)
|
|
||||||
}
|
|
||||||
return &WorkflowRunTrigger{RunID: runID}, nil
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// WorkflowRun represents a Gitea Actions run.
|
// WorkflowRun represents a Gitea Actions run.
|
||||||
|
|||||||
@@ -14,6 +14,9 @@ import (
|
|||||||
"github.com/stretchr/testify/require"
|
"github.com/stretchr/testify/require"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
// Gitea's dispatch endpoint returns 204 No Content with NO Location header.
|
||||||
|
// Dispatch must succeed and forward ref+inputs in the body; the run ID is
|
||||||
|
// resolved separately by the tool via ListWorkflowRuns.
|
||||||
func TestDispatchWorkflow(t *testing.T) {
|
func TestDispatchWorkflow(t *testing.T) {
|
||||||
var gotBody []byte
|
var gotBody []byte
|
||||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
@@ -22,18 +25,17 @@ func TestDispatchWorkflow(t *testing.T) {
|
|||||||
var err error
|
var err error
|
||||||
gotBody, err = io.ReadAll(r.Body)
|
gotBody, err = io.ReadAll(r.Body)
|
||||||
assert.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
w.Header().Set("Location", "/api/v1/repos/o/r/actions/runs/789")
|
// No Location header — matches real Gitea.
|
||||||
w.WriteHeader(http.StatusNoContent)
|
w.WriteHeader(http.StatusNoContent)
|
||||||
}))
|
}))
|
||||||
defer srv.Close()
|
defer srv.Close()
|
||||||
|
|
||||||
c := gitea.NewClient(srv.URL, "tok")
|
c := gitea.NewClient(srv.URL, "tok")
|
||||||
result, err := c.DispatchWorkflow(context.Background(), "o", "r", "ci.yml", gitea.DispatchWorkflowArgs{
|
err := c.DispatchWorkflow(context.Background(), "o", "r", "ci.yml", gitea.DispatchWorkflowArgs{
|
||||||
Ref: "main",
|
Ref: "main",
|
||||||
Inputs: map[string]any{"env": "prod"},
|
Inputs: map[string]any{"env": "prod"},
|
||||||
})
|
})
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
assert.Equal(t, int64(789), result.RunID)
|
|
||||||
|
|
||||||
var body map[string]any
|
var body map[string]any
|
||||||
require.NoError(t, json.Unmarshal(gotBody, &body))
|
require.NoError(t, json.Unmarshal(gotBody, &body))
|
||||||
@@ -43,19 +45,6 @@ func TestDispatchWorkflow(t *testing.T) {
|
|||||||
assert.Equal(t, "prod", inputs["env"])
|
assert.Equal(t, "prod", inputs["env"])
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestDispatchWorkflowMissingLocation(t *testing.T) {
|
|
||||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
||||||
// 204 but no Location header
|
|
||||||
w.WriteHeader(http.StatusNoContent)
|
|
||||||
}))
|
|
||||||
defer srv.Close()
|
|
||||||
|
|
||||||
c := gitea.NewClient(srv.URL, "tok")
|
|
||||||
_, err := c.DispatchWorkflow(context.Background(), "o", "r", "ci.yml", gitea.DispatchWorkflowArgs{Ref: "main"})
|
|
||||||
require.Error(t, err)
|
|
||||||
assert.Contains(t, err.Error(), "Location")
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestDispatchWorkflowError404(t *testing.T) {
|
func TestDispatchWorkflowError404(t *testing.T) {
|
||||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
w.WriteHeader(http.StatusNotFound)
|
w.WriteHeader(http.StatusNotFound)
|
||||||
@@ -63,7 +52,7 @@ func TestDispatchWorkflowError404(t *testing.T) {
|
|||||||
defer srv.Close()
|
defer srv.Close()
|
||||||
|
|
||||||
c := gitea.NewClient(srv.URL, "tok")
|
c := gitea.NewClient(srv.URL, "tok")
|
||||||
_, err := c.DispatchWorkflow(context.Background(), "o", "r", "ci.yml", gitea.DispatchWorkflowArgs{Ref: "main"})
|
err := c.DispatchWorkflow(context.Background(), "o", "r", "ci.yml", gitea.DispatchWorkflowArgs{Ref: "main"})
|
||||||
require.Error(t, err)
|
require.Error(t, err)
|
||||||
assert.True(t, errors.Is(err, gitea.ErrNotFound))
|
assert.True(t, errors.Is(err, gitea.ErrNotFound))
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -8,6 +8,7 @@ import (
|
|||||||
"fmt"
|
"fmt"
|
||||||
"regexp"
|
"regexp"
|
||||||
"strings"
|
"strings"
|
||||||
|
"time"
|
||||||
|
|
||||||
"gitea.d-ma.be/mathias/gitea-mcp/internal/allowlist"
|
"gitea.d-ma.be/mathias/gitea-mcp/internal/allowlist"
|
||||||
"gitea.d-ma.be/mathias/gitea-mcp/internal/gitea"
|
"gitea.d-ma.be/mathias/gitea-mcp/internal/gitea"
|
||||||
@@ -47,7 +48,7 @@ func NewCreateProjectFromTemplate(c *gitea.Client, a *allowlist.Allowlist, tmplO
|
|||||||
func (t *CreateProjectFromTemplate) Descriptor() registry.ToolDescriptor {
|
func (t *CreateProjectFromTemplate) Descriptor() registry.ToolDescriptor {
|
||||||
return registry.ToolDescriptor{
|
return registry.ToolDescriptor{
|
||||||
Name: "create_project_from_template",
|
Name: "create_project_from_template",
|
||||||
Description: "Create a new project repo from a template, substituting placeholders (__PROJECT_NAME__, __MODULE_PATH__) in every file's content AND path (e.g. renaming cmd/__PROJECT_NAME__/) so the result builds. Defaults to the server-configured template; pass template_name to override (e.g. template-go-agent).",
|
Description: "Create a new project repo from a template. Best-effort substitution of placeholders (__PROJECT_NAME__, __MODULE_PATH__) in every file's content AND path (e.g. renaming cmd/__PROJECT_NAME__/): it completes only if the generated branch is promptly writable. If gitea's async generate is slow (infra#179) the repo is still created and partial_failure explains how to finalize locally (`hyperguild new-project`). Check files_substituted and partial_failure. Defaults to the server-configured template; pass template_name to override (e.g. template-go-agent). Pass dispatch_allow=true to also inject a .dispatch-allow file so the project is immediately dispatch-eligible (dispatch#3).",
|
||||||
InputSchema: json.RawMessage(`{
|
InputSchema: json.RawMessage(`{
|
||||||
"type":"object",
|
"type":"object",
|
||||||
"properties":{
|
"properties":{
|
||||||
@@ -55,7 +56,8 @@ func (t *CreateProjectFromTemplate) Descriptor() registry.ToolDescriptor {
|
|||||||
"name":{"type":"string","pattern":"^[a-z][a-z0-9-]{1,38}[a-z0-9]$"},
|
"name":{"type":"string","pattern":"^[a-z][a-z0-9-]{1,38}[a-z0-9]$"},
|
||||||
"description":{"type":"string"},
|
"description":{"type":"string"},
|
||||||
"private":{"type":"boolean"},
|
"private":{"type":"boolean"},
|
||||||
"template_name":{"type":"string","description":"Template repo name to generate from. Defaults to the server-configured template."}
|
"template_name":{"type":"string","description":"Template repo name to generate from. Defaults to the server-configured template."},
|
||||||
|
"dispatch_allow":{"type":"boolean","description":"When true, inject a .dispatch-allow file so the new project is immediately opt-in for headless dispatch (dispatch#3). Default false."}
|
||||||
},
|
},
|
||||||
"required":["owner","name"]
|
"required":["owner","name"]
|
||||||
}`),
|
}`),
|
||||||
@@ -68,8 +70,15 @@ type createProjectArgs struct {
|
|||||||
Description string `json:"description"`
|
Description string `json:"description"`
|
||||||
Private bool `json:"private"`
|
Private bool `json:"private"`
|
||||||
TemplateName string `json:"template_name"`
|
TemplateName string `json:"template_name"`
|
||||||
|
DispatchAllow bool `json:"dispatch_allow"`
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// dispatchAllowContent is the body injected when dispatch_allow=true. Mirrors the
|
||||||
|
// sandbox convention: presence of the file (not its content) marks the repo
|
||||||
|
// dispatch-eligible; the comment exists only to explain that to a human reader.
|
||||||
|
const dispatchAllowContent = "# Presence of this file marks this repo as opt-in for headless dispatch.\n" +
|
||||||
|
"# See dispatch#3.\n"
|
||||||
|
|
||||||
type createProjectResult struct {
|
type createProjectResult struct {
|
||||||
FullName string `json:"full_name"`
|
FullName string `json:"full_name"`
|
||||||
HTMLURL string `json:"html_url"`
|
HTMLURL string `json:"html_url"`
|
||||||
@@ -175,6 +184,39 @@ func (t *CreateProjectFromTemplate) Call(ctx context.Context, raw json.RawMessag
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Opt the new project into headless dispatch if asked: presence of a
|
||||||
|
// .dispatch-allow file on the default branch marks it dispatch-eligible
|
||||||
|
// (dispatch#3). Ride the same upsertRetry path as substitution so it inherits
|
||||||
|
// the infra#179 branch-readiness / partial-failure handling below. Skip if the
|
||||||
|
// loop already stalled — a failed injection then degrades identically.
|
||||||
|
if args.DispatchAllow && result.PartialFailure == "" {
|
||||||
|
const dispatchAllowPath = ".dispatch-allow"
|
||||||
|
if err := t.upsertRetry(ctx, args.Owner, args.Name, dispatchAllowPath, gitea.UpsertFileArgs{
|
||||||
|
Branch: branch,
|
||||||
|
Content: base64.StdEncoding.EncodeToString([]byte(dispatchAllowContent)),
|
||||||
|
Message: "dispatch: mark project dispatch-eligible (dispatch#3)",
|
||||||
|
}); err != nil {
|
||||||
|
result.PartialFailure = fmt.Sprintf("write %s: %v", dispatchAllowPath, err)
|
||||||
|
} else {
|
||||||
|
result.FilesSubstituted = append(result.FilesSubstituted, dispatchAllowPath)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// If substitution stalled because the generated branch wasn't writable in time,
|
||||||
|
// the repo IS created — say so clearly and point to the local finalize step,
|
||||||
|
// rather than leaking the raw "branch does not exist" (infra#179: gitea's
|
||||||
|
// template-generate is slow-async on this instance, so tool-side substitution
|
||||||
|
// is best-effort).
|
||||||
|
if strings.Contains(result.PartialFailure, "branch does not exist") ||
|
||||||
|
strings.Contains(result.PartialFailure, "not found") {
|
||||||
|
result.PartialFailure = fmt.Sprintf(
|
||||||
|
"repo created, but its branch (%s) was not writable within %ds — gitea's "+
|
||||||
|
"template-generate is slow-async on this instance (infra#179), so substitution "+
|
||||||
|
"is incomplete (%d file(s) done). Finalize locally with `hyperguild new-project` "+
|
||||||
|
"(clone + substitute, no API race). Underlying: %s",
|
||||||
|
branch, substitutionBudget, len(result.FilesSubstituted), result.PartialFailure)
|
||||||
|
}
|
||||||
|
|
||||||
// Fail loud: a scaffold that still holds placeholders does not build. Nothing
|
// Fail loud: a scaffold that still holds placeholders does not build. Nothing
|
||||||
// substituted (with no explicit failure) means the walk found no placeholders —
|
// substituted (with no explicit failure) means the walk found no placeholders —
|
||||||
// suspicious for a real template. Surface it instead of returning silent success.
|
// suspicious for a real template. Surface it instead of returning silent success.
|
||||||
@@ -185,6 +227,35 @@ func (t *CreateProjectFromTemplate) Call(ctx context.Context, raw json.RawMessag
|
|||||||
return textOK(result)
|
return textOK(result)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// substitutionBudget bounds how long we retry the first write while the freshly
|
||||||
|
// generated branch becomes writable. gitea's /generate returns (and serves reads)
|
||||||
|
// before the branch ref is committed, so writes 404 "branch does not exist" for a
|
||||||
|
// window. We keep the budget SHORT so the MCP call stays responsive: a healthy
|
||||||
|
// gitea commits in ~1s and this catches it; a slow one (infra#179, observed >40s)
|
||||||
|
// fails fast and we defer substitution with clear guidance rather than hang.
|
||||||
|
const substitutionBudget = 5
|
||||||
|
|
||||||
|
// upsertRetry retries UpsertFile on the transient post-generate "branch does not
|
||||||
|
// exist" not-found, up to substitutionBudget. The write itself is the readiness
|
||||||
|
// probe — BranchExists reports the branch present before writes succeed.
|
||||||
|
func (t *CreateProjectFromTemplate) upsertRetry(ctx context.Context, owner, name, path string, args gitea.UpsertFileArgs) error {
|
||||||
|
var err error
|
||||||
|
for i := 0; i < substitutionBudget; i++ {
|
||||||
|
if _, err = t.c.UpsertFile(ctx, owner, name, path, args); err == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
if !errors.Is(err, gitea.ErrNotFound) {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case <-ctx.Done():
|
||||||
|
return err
|
||||||
|
case <-time.After(time.Second):
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
// substituteEntry substitutes placeholders in one blob. If the path carries a
|
// substituteEntry substitutes placeholders in one blob. If the path carries a
|
||||||
// placeholder it renames the file (write new + delete old); otherwise it rewrites
|
// placeholder it renames the file (write new + delete old); otherwise it rewrites
|
||||||
// content in place when changed. Returns a human-readable description of what was
|
// content in place when changed. Returns a human-readable description of what was
|
||||||
@@ -212,7 +283,7 @@ func (t *CreateProjectFromTemplate) substituteEntry(ctx context.Context, owner,
|
|||||||
enc := base64.StdEncoding.EncodeToString([]byte(newContent))
|
enc := base64.StdEncoding.EncodeToString([]byte(newContent))
|
||||||
|
|
||||||
if renamed {
|
if renamed {
|
||||||
if _, err := t.c.UpsertFile(ctx, owner, name, newPath, gitea.UpsertFileArgs{
|
if err := t.upsertRetry(ctx, owner, name, newPath, gitea.UpsertFileArgs{
|
||||||
Branch: branch,
|
Branch: branch,
|
||||||
Content: enc,
|
Content: enc,
|
||||||
Message: fmt.Sprintf("template: substitute + rename %s -> %s", path, newPath),
|
Message: fmt.Sprintf("template: substitute + rename %s -> %s", path, newPath),
|
||||||
@@ -229,7 +300,7 @@ func (t *CreateProjectFromTemplate) substituteEntry(ctx context.Context, owner,
|
|||||||
return path + " -> " + newPath, ""
|
return path + " -> " + newPath, ""
|
||||||
}
|
}
|
||||||
|
|
||||||
if _, err := t.c.UpsertFile(ctx, owner, name, path, gitea.UpsertFileArgs{
|
if err := t.upsertRetry(ctx, owner, name, path, gitea.UpsertFileArgs{
|
||||||
Branch: branch,
|
Branch: branch,
|
||||||
Content: enc,
|
Content: enc,
|
||||||
Message: "template: substitute placeholders",
|
Message: "template: substitute placeholders",
|
||||||
|
|||||||
@@ -226,6 +226,38 @@ func TestCreateProject_WriteFailure_PartialFailure(t *testing.T) {
|
|||||||
assert.Contains(t, out.PartialFailure, "go.mod")
|
assert.Contains(t, out.PartialFailure, "go.mod")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// dispatch_allow injects a .dispatch-allow file (dispatch#3) only when true.
|
||||||
|
func TestCreateProject_DispatchAllow(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
argsJSON string
|
||||||
|
wantFile bool
|
||||||
|
}{
|
||||||
|
{"true injects .dispatch-allow", `{"owner":"mathias","name":"new-svc","dispatch_allow":true}`, true},
|
||||||
|
{"false does not inject", `{"owner":"mathias","name":"new-svc","dispatch_allow":false}`, false},
|
||||||
|
{"omitted does not inject", `{"owner":"mathias","name":"new-svc"}`, false},
|
||||||
|
}
|
||||||
|
for _, tc := range tests {
|
||||||
|
t.Run(tc.name, func(t *testing.T) {
|
||||||
|
files := map[string]string{"go.mod": "module __MODULE_PATH__\n"}
|
||||||
|
f := newFakeTemplateServer(files, "main")
|
||||||
|
srv := httptest.NewServer(f.handler(t, "template-go-agent", "new-svc"))
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
out := callTool(t, srv.URL, "template-go-agent", tc.argsJSON)
|
||||||
|
require.Empty(t, out.PartialFailure)
|
||||||
|
if tc.wantFile {
|
||||||
|
assert.Contains(t, out.FilesSubstituted, ".dispatch-allow")
|
||||||
|
assert.Contains(t, f.puts, ".dispatch-allow")
|
||||||
|
assert.Contains(t, f.putBodies[".dispatch-allow"], "dispatch#3")
|
||||||
|
} else {
|
||||||
|
assert.NotContains(t, out.FilesSubstituted, ".dispatch-allow")
|
||||||
|
assert.NotContains(t, f.puts, ".dispatch-allow")
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// ── guardrails unchanged by the rewrite ──────────────────────────────────────
|
// ── guardrails unchanged by the rewrite ──────────────────────────────────────
|
||||||
|
|
||||||
func TestCreateProject_NameRegexFailure(t *testing.T) {
|
func TestCreateProject_NameRegexFailure(t *testing.T) {
|
||||||
|
|||||||
@@ -4,12 +4,22 @@ import (
|
|||||||
"context"
|
"context"
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"time"
|
||||||
|
|
||||||
"gitea.d-ma.be/mathias/gitea-mcp/internal/allowlist"
|
"gitea.d-ma.be/mathias/gitea-mcp/internal/allowlist"
|
||||||
"gitea.d-ma.be/mathias/gitea-mcp/internal/gitea"
|
"gitea.d-ma.be/mathias/gitea-mcp/internal/gitea"
|
||||||
"gitea.d-ma.be/mathias/gitea-mcp/internal/registry"
|
"gitea.d-ma.be/mathias/gitea-mcp/internal/registry"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
// dispatchResolveBudget bounds how many times we poll for the dispatched run to
|
||||||
|
// appear, and dispatchResolvePoll is the gap between polls. Gitea returns 204
|
||||||
|
// with no run ID, so we list workflow_dispatch runs and take the newest above
|
||||||
|
// the pre-dispatch baseline; it may register a beat after the 204.
|
||||||
|
const (
|
||||||
|
dispatchResolveBudget = 5
|
||||||
|
dispatchResolvePoll = time.Second
|
||||||
|
)
|
||||||
|
|
||||||
// WorkflowRunTrigger triggers a Gitea Actions workflow_dispatch run.
|
// WorkflowRunTrigger triggers a Gitea Actions workflow_dispatch run.
|
||||||
type WorkflowRunTrigger struct {
|
type WorkflowRunTrigger struct {
|
||||||
c *gitea.Client
|
c *gitea.Client
|
||||||
@@ -68,17 +78,82 @@ func (t *WorkflowRunTrigger) Call(ctx context.Context, raw json.RawMessage) (jso
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
result, err := t.c.DispatchWorkflow(ctx, args.Owner, args.Name, args.Workflow, gitea.DispatchWorkflowArgs{
|
// Snapshot the newest existing workflow_dispatch run BEFORE dispatching, so we
|
||||||
|
// can tell our fresh run apart from a prior one (Gitea's 204 carries no run ID).
|
||||||
|
baseline := t.newestDispatchRunID(ctx, args.Owner, args.Name, args.Workflow, ref)
|
||||||
|
|
||||||
|
if err := t.c.DispatchWorkflow(ctx, args.Owner, args.Name, args.Workflow, gitea.DispatchWorkflowArgs{
|
||||||
Ref: ref,
|
Ref: ref,
|
||||||
Inputs: args.Inputs,
|
Inputs: args.Inputs,
|
||||||
})
|
}); err != nil {
|
||||||
if err != nil {
|
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
|
||||||
htmlURL := fmt.Sprintf("%s/%s/%s/actions/runs/%d", t.baseURL, args.Owner, args.Name, result.RunID)
|
// Resolve the new run by listing workflow_dispatch runs and taking the newest
|
||||||
|
// one whose ID exceeds the baseline. Poll briefly: the run can register a beat
|
||||||
|
// after the 204.
|
||||||
|
var run *gitea.WorkflowRun
|
||||||
|
for i := 0; i < dispatchResolveBudget; i++ {
|
||||||
|
if i > 0 {
|
||||||
|
select {
|
||||||
|
case <-ctx.Done():
|
||||||
|
return nil, ctx.Err()
|
||||||
|
case <-time.After(dispatchResolvePoll):
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if r := t.newestDispatchRun(ctx, args.Owner, args.Name, args.Workflow, ref); r != nil && r.ID > baseline {
|
||||||
|
run = r
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Dispatch succeeded (204). If the run has not surfaced yet, say so honestly
|
||||||
|
// rather than failing — the workflow IS firing; the caller can list runs.
|
||||||
|
if run == nil {
|
||||||
return textOK(map[string]any{
|
return textOK(map[string]any{
|
||||||
"run_id": result.RunID,
|
"dispatched": true,
|
||||||
|
"note": "dispatch accepted but the run did not register within the resolve window; " +
|
||||||
|
"list recent workflow_dispatch runs to find it",
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
htmlURL := run.HTMLURL
|
||||||
|
if htmlURL == "" {
|
||||||
|
htmlURL = fmt.Sprintf("%s/%s/%s/actions/runs/%d", t.baseURL, args.Owner, args.Name, run.ID)
|
||||||
|
}
|
||||||
|
return textOK(map[string]any{
|
||||||
|
"dispatched": true,
|
||||||
|
"run_id": run.ID,
|
||||||
"html_url": htmlURL,
|
"html_url": htmlURL,
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// newestDispatchRun returns the most recent workflow_dispatch run for the given
|
||||||
|
// workflow and ref, or nil if none / on listing error (best-effort resolution).
|
||||||
|
func (t *WorkflowRunTrigger) newestDispatchRun(ctx context.Context, owner, name, workflow, ref string) *gitea.WorkflowRun {
|
||||||
|
resp, err := t.c.ListWorkflowRuns(ctx, owner, name, gitea.ListWorkflowRunsArgs{
|
||||||
|
Event: "workflow_dispatch",
|
||||||
|
Workflow: workflow,
|
||||||
|
Branch: ref,
|
||||||
|
Limit: 20,
|
||||||
|
})
|
||||||
|
if err != nil || resp == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
var newest *gitea.WorkflowRun
|
||||||
|
for i := range resp.WorkflowRuns {
|
||||||
|
r := &resp.WorkflowRuns[i]
|
||||||
|
if newest == nil || r.ID > newest.ID {
|
||||||
|
newest = r
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return newest
|
||||||
|
}
|
||||||
|
|
||||||
|
// newestDispatchRunID is newestDispatchRun's ID, or 0 if none.
|
||||||
|
func (t *WorkflowRunTrigger) newestDispatchRunID(ctx context.Context, owner, name, workflow, ref string) int64 {
|
||||||
|
if r := t.newestDispatchRun(ctx, owner, name, workflow, ref); r != nil {
|
||||||
|
return r.ID
|
||||||
|
}
|
||||||
|
return 0
|
||||||
|
}
|
||||||
|
|||||||
@@ -3,8 +3,10 @@ package tools_test
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
|
"io"
|
||||||
"net/http"
|
"net/http"
|
||||||
"net/http/httptest"
|
"net/http/httptest"
|
||||||
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"gitea.d-ma.be/mathias/gitea-mcp/internal/allowlist"
|
"gitea.d-ma.be/mathias/gitea-mcp/internal/allowlist"
|
||||||
@@ -14,10 +16,67 @@ import (
|
|||||||
"github.com/stretchr/testify/require"
|
"github.com/stretchr/testify/require"
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestWorkflowRunTriggerSuccess(t *testing.T) {
|
// runsListJSON is a workflow_runs listing body with a single run of the given id.
|
||||||
// Fake server handles both the repo endpoint (default_branch) and the dispatch endpoint.
|
func runsListJSON(id int) string {
|
||||||
|
return `{"total_count":1,"workflow_runs":[{"id":` +
|
||||||
|
fmtInt(id) +
|
||||||
|
`,"status":"queued","event":"workflow_dispatch","html_url":"http://gitea.example/mathias/myrepo/actions/runs/` +
|
||||||
|
fmtInt(id) + `"}]}`
|
||||||
|
}
|
||||||
|
|
||||||
|
func fmtInt(i int) string { b, _ := json.Marshal(i); return string(b) }
|
||||||
|
|
||||||
|
// The dispatch endpoint returns 204 with NO Location header (real Gitea). The
|
||||||
|
// tool must treat that as success, forward inputs, and resolve the new run by
|
||||||
|
// listing workflow_dispatch runs and picking the newest one above the
|
||||||
|
// pre-dispatch baseline.
|
||||||
|
func TestWorkflowRunTriggerResolvesRunViaListing(t *testing.T) {
|
||||||
|
dispatched := false
|
||||||
|
var gotBody []byte
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
switch {
|
||||||
|
case r.URL.Path == "/api/v1/repos/mathias/myrepo/actions/workflows/ci.yml/dispatches" && r.Method == http.MethodPost:
|
||||||
|
gotBody, _ = io.ReadAll(r.Body)
|
||||||
|
dispatched = true
|
||||||
|
w.WriteHeader(http.StatusNoContent) // no Location header
|
||||||
|
case strings.HasPrefix(r.URL.Path, "/api/v1/repos/mathias/myrepo/actions/runs"):
|
||||||
|
w.Header().Set("Content-Type", "application/json")
|
||||||
|
if !dispatched {
|
||||||
|
_, _ = w.Write([]byte(`{"total_count":0,"workflow_runs":[]}`)) // baseline: none yet
|
||||||
|
return
|
||||||
|
}
|
||||||
|
_, _ = w.Write([]byte(runsListJSON(100)))
|
||||||
|
default:
|
||||||
|
http.NotFound(w, r)
|
||||||
|
}
|
||||||
|
}))
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
tool := tools.NewWorkflowRunTrigger(gitea.NewClient(srv.URL, "tok"), allowlist.New([]string{"mathias"}), srv.URL)
|
||||||
|
out, err := tool.Call(context.Background(), json.RawMessage(
|
||||||
|
`{"owner":"mathias","name":"myrepo","workflow":"ci.yml","ref":"main","inputs":{"issue_number":"36","harness":"agentsquad"}}`))
|
||||||
|
require.NoError(t, err)
|
||||||
|
assert.True(t, dispatched, "expected POST dispatch")
|
||||||
|
|
||||||
|
// inputs forwarded to the dispatch body
|
||||||
|
var body map[string]any
|
||||||
|
require.NoError(t, json.Unmarshal(gotBody, &body))
|
||||||
|
assert.Equal(t, "main", body["ref"])
|
||||||
|
inputs, ok := body["inputs"].(map[string]any)
|
||||||
|
require.True(t, ok, "inputs must be present in dispatch body")
|
||||||
|
assert.Equal(t, "36", inputs["issue_number"])
|
||||||
|
assert.Equal(t, "agentsquad", inputs["harness"])
|
||||||
|
|
||||||
|
// run id resolved via listing (not a Location header)
|
||||||
|
var result map[string]any
|
||||||
|
require.NoError(t, json.Unmarshal(out, &result))
|
||||||
|
assert.Equal(t, float64(100), result["run_id"])
|
||||||
|
assert.Contains(t, result["html_url"], "/actions/runs/100")
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestWorkflowRunTriggerDefaultBranch(t *testing.T) {
|
||||||
repoHit := false
|
repoHit := false
|
||||||
dispatchHit := false
|
dispatched := false
|
||||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
switch {
|
switch {
|
||||||
case r.URL.Path == "/api/v1/repos/mathias/myrepo" && r.Method == http.MethodGet:
|
case r.URL.Path == "/api/v1/repos/mathias/myrepo" && r.Method == http.MethodGet:
|
||||||
@@ -25,9 +84,15 @@ func TestWorkflowRunTriggerSuccess(t *testing.T) {
|
|||||||
w.Header().Set("Content-Type", "application/json")
|
w.Header().Set("Content-Type", "application/json")
|
||||||
_, _ = w.Write([]byte(`{"name":"myrepo","full_name":"mathias/myrepo","default_branch":"main"}`))
|
_, _ = w.Write([]byte(`{"name":"myrepo","full_name":"mathias/myrepo","default_branch":"main"}`))
|
||||||
case r.URL.Path == "/api/v1/repos/mathias/myrepo/actions/workflows/ci.yml/dispatches" && r.Method == http.MethodPost:
|
case r.URL.Path == "/api/v1/repos/mathias/myrepo/actions/workflows/ci.yml/dispatches" && r.Method == http.MethodPost:
|
||||||
dispatchHit = true
|
dispatched = true
|
||||||
w.Header().Set("Location", "/api/v1/repos/mathias/myrepo/actions/runs/42")
|
|
||||||
w.WriteHeader(http.StatusNoContent)
|
w.WriteHeader(http.StatusNoContent)
|
||||||
|
case strings.HasPrefix(r.URL.Path, "/api/v1/repos/mathias/myrepo/actions/runs"):
|
||||||
|
w.Header().Set("Content-Type", "application/json")
|
||||||
|
if !dispatched {
|
||||||
|
_, _ = w.Write([]byte(`{"total_count":0,"workflow_runs":[]}`))
|
||||||
|
return
|
||||||
|
}
|
||||||
|
_, _ = w.Write([]byte(runsListJSON(55)))
|
||||||
default:
|
default:
|
||||||
http.NotFound(w, r)
|
http.NotFound(w, r)
|
||||||
}
|
}
|
||||||
@@ -38,37 +103,10 @@ func TestWorkflowRunTriggerSuccess(t *testing.T) {
|
|||||||
out, err := tool.Call(context.Background(), json.RawMessage(`{"owner":"mathias","name":"myrepo","workflow":"ci.yml"}`))
|
out, err := tool.Call(context.Background(), json.RawMessage(`{"owner":"mathias","name":"myrepo","workflow":"ci.yml"}`))
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
assert.True(t, repoHit, "expected GET /repo for default branch")
|
assert.True(t, repoHit, "expected GET /repo for default branch")
|
||||||
assert.True(t, dispatchHit, "expected POST dispatch")
|
|
||||||
|
|
||||||
var result map[string]any
|
var result map[string]any
|
||||||
require.NoError(t, json.Unmarshal(out, &result))
|
require.NoError(t, json.Unmarshal(out, &result))
|
||||||
assert.Equal(t, float64(42), result["run_id"])
|
assert.Equal(t, float64(55), result["run_id"])
|
||||||
assert.Contains(t, result["html_url"], "/mathias/myrepo/actions/runs/42")
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestWorkflowRunTriggerExplicitRef(t *testing.T) {
|
|
||||||
repoHit := false
|
|
||||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
||||||
if r.URL.Path == "/api/v1/repos/mathias/myrepo" {
|
|
||||||
repoHit = true
|
|
||||||
}
|
|
||||||
if r.URL.Path == "/api/v1/repos/mathias/myrepo/actions/workflows/ci.yml/dispatches" {
|
|
||||||
w.Header().Set("Location", "/api/v1/repos/mathias/myrepo/actions/runs/99")
|
|
||||||
w.WriteHeader(http.StatusNoContent)
|
|
||||||
return
|
|
||||||
}
|
|
||||||
http.NotFound(w, r)
|
|
||||||
}))
|
|
||||||
defer srv.Close()
|
|
||||||
|
|
||||||
tool := tools.NewWorkflowRunTrigger(gitea.NewClient(srv.URL, "tok"), allowlist.New([]string{"mathias"}), srv.URL)
|
|
||||||
out, err := tool.Call(context.Background(), json.RawMessage(`{"owner":"mathias","name":"myrepo","workflow":"ci.yml","ref":"develop"}`))
|
|
||||||
require.NoError(t, err)
|
|
||||||
assert.False(t, repoHit, "should not call GET /repo when ref is provided")
|
|
||||||
|
|
||||||
var result map[string]any
|
|
||||||
require.NoError(t, json.Unmarshal(out, &result))
|
|
||||||
assert.Equal(t, float64(99), result["run_id"])
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestWorkflowRunTriggerAllowlistRejects(t *testing.T) {
|
func TestWorkflowRunTriggerAllowlistRejects(t *testing.T) {
|
||||||
|
|||||||
Reference in New Issue
Block a user