mathiasandClaude Sonnet 5
43714047be
Allowlist.Check now takes ctx: when the caller authenticated with their own Gitea PAT (pass-through, v0.12.0), it skips the static GITEA_MCP_ALLOWED_OWNERS check entirely — Gitea's own permission model already gates that caller's access more precisely than a coarse owner-name list can. The static list still applies unchanged for the shared static-token/JWT path, where it's the only defense against the service token's blast radius. Mechanical: every tool call site already had ctx in scope, so this is a signature-only change at 41 call sites, no other tool behavior changes. Closes the "Deferred" item from #59. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
74 lines
1.8 KiB
Go
74 lines
1.8 KiB
Go
package tools
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
|
|
"git.d-ma.be/mathias/gitea-mcp/internal/allowlist"
|
|
"git.d-ma.be/mathias/gitea-mcp/internal/auth"
|
|
"git.d-ma.be/mathias/gitea-mcp/internal/gitea"
|
|
"git.d-ma.be/mathias/gitea-mcp/internal/identity"
|
|
"git.d-ma.be/mathias/gitea-mcp/internal/registry"
|
|
)
|
|
|
|
type PRComment struct {
|
|
c *gitea.Client
|
|
a *allowlist.Allowlist
|
|
}
|
|
|
|
func NewPRComment(c *gitea.Client, a *allowlist.Allowlist) *PRComment {
|
|
return &PRComment{c: c, a: a}
|
|
}
|
|
|
|
func (t *PRComment) Descriptor() registry.ToolDescriptor {
|
|
return registry.ToolDescriptor{
|
|
Name: "pr_comment",
|
|
Description: "Comment on a pull request (conversation, not inline review). Applies identity footer.",
|
|
InputSchema: json.RawMessage(`{
|
|
"type":"object",
|
|
"properties":{
|
|
"owner":{"type":"string"},
|
|
"repo":{"type":"string"},
|
|
"number":{"type":"integer","minimum":1},
|
|
"body":{"type":"string"}
|
|
},
|
|
"required":["owner","repo","number","body"]
|
|
}`),
|
|
}
|
|
}
|
|
|
|
type prCommentArgs struct {
|
|
Owner string `json:"owner"`
|
|
Repo string `json:"repo"`
|
|
Number int `json:"number"`
|
|
Body string `json:"body"`
|
|
}
|
|
|
|
func (t *PRComment) Call(ctx context.Context, raw json.RawMessage) (json.RawMessage, error) {
|
|
var args prCommentArgs
|
|
if err := parseArgs(raw, &args); err != nil {
|
|
return nil, err
|
|
}
|
|
if err := t.a.Check(ctx, args.Owner); err != nil {
|
|
return nil, err
|
|
}
|
|
if args.Number < 1 {
|
|
return nil, fmt.Errorf("number must be >= 1: %w", gitea.ErrValidation)
|
|
}
|
|
if args.Body == "" {
|
|
return nil, fmt.Errorf("body is required: %w", gitea.ErrValidation)
|
|
}
|
|
body := identity.ApplyFooter(args.Body, auth.Caller(ctx))
|
|
|
|
c, err := t.c.CreateIssueComment(ctx, args.Owner, args.Repo, args.Number, body)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return textOK(map[string]any{
|
|
"id": c.ID,
|
|
"html_url": c.HTMLURL,
|
|
})
|
|
}
|