mathiasandClaude Sonnet 5
43714047be
Allowlist.Check now takes ctx: when the caller authenticated with their own Gitea PAT (pass-through, v0.12.0), it skips the static GITEA_MCP_ALLOWED_OWNERS check entirely — Gitea's own permission model already gates that caller's access more precisely than a coarse owner-name list can. The static list still applies unchanged for the shared static-token/JWT path, where it's the only defense against the service token's blast radius. Mechanical: every tool call site already had ctx in scope, so this is a signature-only change at 41 call sites, no other tool behavior changes. Closes the "Deferred" item from #59. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
79 lines
1.9 KiB
Go
79 lines
1.9 KiB
Go
package tools
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
|
|
"git.d-ma.be/mathias/gitea-mcp/internal/allowlist"
|
|
"git.d-ma.be/mathias/gitea-mcp/internal/gitea"
|
|
"git.d-ma.be/mathias/gitea-mcp/internal/registry"
|
|
)
|
|
|
|
type FileDelete struct {
|
|
c *gitea.Client
|
|
a *allowlist.Allowlist
|
|
}
|
|
|
|
func NewFileDelete(c *gitea.Client, a *allowlist.Allowlist) *FileDelete {
|
|
return &FileDelete{c: c, a: a}
|
|
}
|
|
|
|
func (t *FileDelete) Descriptor() registry.ToolDescriptor {
|
|
return registry.ToolDescriptor{
|
|
Name: "file_delete",
|
|
Description: "Delete a file from a repository branch. sha is the current blob SHA (from file_read).",
|
|
InputSchema: json.RawMessage(`{
|
|
"type":"object",
|
|
"properties":{
|
|
"owner":{"type":"string"},
|
|
"repo":{"type":"string"},
|
|
"path":{"type":"string"},
|
|
"branch":{"type":"string"},
|
|
"message":{"type":"string"},
|
|
"sha":{"type":"string"}
|
|
},
|
|
"required":["owner","repo","path","branch","message","sha"]
|
|
}`),
|
|
}
|
|
}
|
|
|
|
type fileDeleteArgs struct {
|
|
Owner string `json:"owner"`
|
|
Repo string `json:"repo"`
|
|
Path string `json:"path"`
|
|
Branch string `json:"branch"`
|
|
Message string `json:"message"`
|
|
Sha string `json:"sha"`
|
|
}
|
|
|
|
func (t *FileDelete) Call(ctx context.Context, raw json.RawMessage) (json.RawMessage, error) {
|
|
var args fileDeleteArgs
|
|
if err := parseArgs(raw, &args); err != nil {
|
|
return nil, err
|
|
}
|
|
if err := t.a.Check(ctx, args.Owner); err != nil {
|
|
return nil, err
|
|
}
|
|
if args.Sha == "" {
|
|
return nil, fmt.Errorf("sha is required: %w", gitea.ErrValidation)
|
|
}
|
|
if args.Message == "" {
|
|
return nil, fmt.Errorf("message is required: %w", gitea.ErrValidation)
|
|
}
|
|
|
|
result, err := t.c.DeleteFile(ctx, args.Owner, args.Repo, args.Path, gitea.DeleteFileArgs{
|
|
Branch: args.Branch,
|
|
Message: args.Message,
|
|
Sha: args.Sha,
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return textOK(map[string]any{
|
|
"commit_sha": result.Commit.Sha,
|
|
"html_url": result.Commit.HTMLURL,
|
|
})
|
|
}
|