mathiasandClaude Sonnet 5
43714047be
Allowlist.Check now takes ctx: when the caller authenticated with their own Gitea PAT (pass-through, v0.12.0), it skips the static GITEA_MCP_ALLOWED_OWNERS check entirely — Gitea's own permission model already gates that caller's access more precisely than a coarse owner-name list can. The static list still applies unchanged for the shared static-token/JWT path, where it's the only defense against the service token's blast radius. Mechanical: every tool call site already had ctx in scope, so this is a signature-only change at 41 call sites, no other tool behavior changes. Closes the "Deferred" item from #59. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
89 lines
2.0 KiB
Go
89 lines
2.0 KiB
Go
package tools
|
|
|
|
import (
|
|
"context"
|
|
"encoding/base64"
|
|
"encoding/json"
|
|
"fmt"
|
|
|
|
"git.d-ma.be/mathias/gitea-mcp/internal/allowlist"
|
|
"git.d-ma.be/mathias/gitea-mcp/internal/gitea"
|
|
"git.d-ma.be/mathias/gitea-mcp/internal/registry"
|
|
)
|
|
|
|
const fileReadMaxBytes = 1 << 20 // 1 MiB
|
|
|
|
type FileRead struct {
|
|
c *gitea.Client
|
|
a *allowlist.Allowlist
|
|
}
|
|
|
|
func NewFileRead(c *gitea.Client, a *allowlist.Allowlist) *FileRead {
|
|
return &FileRead{c: c, a: a}
|
|
}
|
|
|
|
func (t *FileRead) Descriptor() registry.ToolDescriptor {
|
|
return registry.ToolDescriptor{
|
|
Name: "file_read",
|
|
Description: "Read a file from a repo at a given ref. Defaults to the repo's default branch.",
|
|
InputSchema: json.RawMessage(`{
|
|
"type":"object",
|
|
"properties":{
|
|
"owner":{"type":"string"},
|
|
"repo":{"type":"string"},
|
|
"path":{"type":"string"},
|
|
"ref":{"type":"string"}
|
|
},
|
|
"required":["owner","repo","path"]
|
|
}`),
|
|
}
|
|
}
|
|
|
|
type fileReadArgs struct {
|
|
Owner string `json:"owner"`
|
|
Repo string `json:"repo"`
|
|
Path string `json:"path"`
|
|
Ref string `json:"ref"`
|
|
}
|
|
|
|
func (t *FileRead) Call(ctx context.Context, raw json.RawMessage) (json.RawMessage, error) {
|
|
var args fileReadArgs
|
|
if err := parseArgs(raw, &args); err != nil {
|
|
return nil, err
|
|
}
|
|
if err := t.a.Check(ctx, args.Owner); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
ref := args.Ref
|
|
if ref == "" {
|
|
var err error
|
|
ref, err = t.c.DefaultBranch(ctx, args.Owner, args.Repo)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
fc, err := t.c.GetFileContents(ctx, args.Owner, args.Repo, args.Path, ref)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if fc.Size > fileReadMaxBytes {
|
|
return nil, fmt.Errorf("file %q size %d exceeds 1MiB cap: %w", args.Path, fc.Size, gitea.ErrValidation)
|
|
}
|
|
|
|
decoded, err := base64.StdEncoding.DecodeString(fc.Content)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("decode base64 content: %w", err)
|
|
}
|
|
|
|
return textOK(map[string]any{
|
|
"path": fc.Path,
|
|
"ref": ref,
|
|
"sha": fc.Sha,
|
|
"size": fc.Size,
|
|
"content": string(decoded),
|
|
})
|
|
}
|