From e614d39e0653a1838d873146ede47f2172736c4f Mon Sep 17 00:00:00 2001 From: Mathias Date: Mon, 5 Oct 2026 22:55:36 +0200 Subject: [PATCH] test(symlinkguard): an unremovable special file must not be reported as removed (#179) Review round 2 on PR #190: swallowing root.Remove's error in removeSpecial left every test green (the false 'removed' alert also named the file). The test now asserts no message says 'removed'; red under that flip. Co-Authored-By: Claude Opus 5.5 --- ingestion/internal/symlinkguard/special_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ingestion/internal/symlinkguard/special_test.go b/ingestion/internal/symlinkguard/special_test.go index f592ff4..24ad902 100644 --- a/ingestion/internal/symlinkguard/special_test.go +++ b/ingestion/internal/symlinkguard/special_test.go @@ -98,4 +98,7 @@ func TestWatchReportsASpecialFileItCannotRemove(t *testing.T) { defer n.mu.Unlock() assert.Contains(t, n.msgs[0], "ro/f.md") assert.Contains(t, n.msgs[0], "special file") + for _, m := range n.msgs { + assert.NotContains(t, m, "removed", "a file it could not remove was reported as removed") + } }