mathias/hyperguild
1
0
Fork 0
Code Issues 30 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

provenance follow-ups: decode written_by on read; promote leaves empty dir on refusal; partial multi-page ingest #151

New Issue
Open
opened 2026-10-01 21:07:17 +00:00 by mathias · 0 comments
mathias commented 2026-10-01 21:07:17 +00:00
Owner
Copy Link
Copy Source

Follow-ups from the pr-gatekeeper review of #147 (round 4, merged as a6da933). None of these lets a caller forge provenance; each is reproduced by execution.

  1. The read side doesn't decode the written_by scalar. search.extractProvenance trims "' instead of decoding YAML. A JWT subject 'local-cli' is stamped written_by: "'local-cli'", and brain_query reports written_by=local-cli (origin stays jwt). Principal "local-cli" shows as \"local-cli\, and a\nb keeps its escape. brain_get's frontmatter map returns the raw quoted text. Fix: decode the value with yaml.v3 (or the shared parser) in both readers, and test with 'local-cli'.
  2. A refused promote leaves an empty wing directory. api.PromoteNote calls MkdirAll before StampProvenance. Repro: a principal that fails verify (JWT subject bad\xff), then brain_promote into a new wing; the source survives but wiki/<wing>/ is left behind. Same brain#21 invariant that writeHallNote now honours.
  3. Partial multi-page ingest. pipeline.buildAndWrite stamps and writes page by page. If a later page can't be stamped (e.g. an existing page on disk with an unclosable ---x fence), earlier pages stay written, each correctly stamped, and the call returns an error. Decide whether to stamp everything first and write after.

Source: #147

Follow-ups from the pr-gatekeeper review of #147 (round 4, merged as a6da933). None of these lets a caller forge provenance; each is reproduced by execution. 1. **The read side doesn't decode the written_by scalar.** `search.extractProvenance` trims `"'` instead of decoding YAML. A JWT subject `'local-cli'` is stamped `written_by: "'local-cli'"`, and brain_query reports `written_by=local-cli` (origin stays `jwt`). Principal `"local-cli"` shows as `\"local-cli\`, and `a\nb` keeps its escape. brain_get's `frontmatter` map returns the raw quoted text. Fix: decode the value with yaml.v3 (or the shared parser) in both readers, and test with `'local-cli'`. 2. **A refused promote leaves an empty wing directory.** `api.PromoteNote` calls MkdirAll before `StampProvenance`. Repro: a principal that fails verify (JWT subject `bad\xff`), then brain_promote into a new wing; the source survives but `wiki/<wing>/` is left behind. Same brain#21 invariant that writeHallNote now honours. 3. **Partial multi-page ingest.** `pipeline.buildAndWrite` stamps and writes page by page. If a later page can't be stamped (e.g. an existing page on disk with an unclosable `---x` fence), earlier pages stay written, each correctly stamped, and the call returns an error. Decide whether to stamp everything first and write after. Source: https://git.d-ma.be/mathias/hyperguild/pulls/147
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agent/ready
Meets the agent-ready contract; authorizes unattended execution
 blocked/client
Waiting on the client
 blocked/supplier
Waiting on a supplier
 blocked/upstream
Waiting on an upstream project or vendor
 risk/high
Irreversible, security-relevant, or control plane
 risk/low
Reversible, local, test-covered
 risk/medium
Touches shared state, deploys or data
 size/l
Too big - split it
 size/m
Under two days
 size/s
Under half a day
 size/xs
Under an hour
 status:dispatch
status:dispatched
status:review
status:reviewing
type/chore
Maintenance, no behaviour change
 type/decision
Human decision required; never agent/ready
 type/docs
Documentation only
 type/feat
New capability
 type/fix
Corrects broken behaviour
 type/ops
Infrastructure, deploy, runtime
 type/research
Investigate; output is a finding, not code
 type/test
Test coverage only
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
renovate-bot mathias
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mathias/hyperguild#151