brainfstest: swap-race asserts can pass vacuously (no read/iteration floor, swallowed Query errors) #177

New Issue

2026-10-05T05:21:10Z

mathias commented

2026-10-05 05:21:10 +00:00

These came out of the #172 review (comment 15358, findings 3 and 4). They don't block that PR. Both were confirmed by running the code.

The Query race reader ignores Query's error, and its test has no positive control (internal/search/brainroot_test.go, the in-brain Query race test). When brainfs.Open was pointed at a directory that doesn't exist, every Query call failed. The race test still passed, while 11 other tests in the package went red. Fix: require at least one successful read that returns the inside note.
brainfstest.AssertNoLeakFrom sets no minimum on iterations or successful reads, and the swapper ignores os.Symlink errors (_ =). If every symlink fails to be created, every leak assertion passes without testing anything. Fix: count successful swaps and successful reads, then fail if either one is 0. Keeping a floor such as ≥1 swap and ≥1 inside-read keeps it flake-free.

Same family as rule 9 and the infra#506 lesson: an assertion that can't fail tests nothing.

Created via git-mcp on behalf of @mathias

These came out of the #172 review (comment 15358, findings 3 and 4). They don't block that PR. Both were confirmed by running the code. 1. **The Query race reader ignores Query's error, and its test has no positive control** (`internal/search/brainroot_test.go`, the in-brain Query race test). When `brainfs.Open` was pointed at a directory that doesn't exist, every Query call failed. The race test still passed, while 11 other tests in the package went red. Fix: require at least one successful read that returns the inside note. 2. **`brainfstest.AssertNoLeakFrom` sets no minimum on iterations or successful reads, and the swapper ignores `os.Symlink` errors** (`_ =`). If every symlink fails to be created, every leak assertion passes without testing anything. Fix: count successful swaps and successful reads, then fail if either one is 0. Keeping a floor such as ≥1 swap and ≥1 inside-read keeps it flake-free. Same family as rule 9 and the infra#506 lesson: an assertion that can't fail tests nothing. --- _Created via git-mcp on behalf of @mathias_

mathias referenced this issue from a commit

2026-10-05 07:32:27 +00:00

test(brainfstest): swap-race asserts fail when nothing was tested

mathias closed this issue

2026-10-05 07:32:27 +00:00

mathias referenced this issue from a commit

2026-10-05 14:20:42 +00:00

test(search): in-brain Query race queries the inside note too

mathias referenced this issue

2026-10-05 14:20:46 +00:00

test(brainfs): per-caller in-brain symlink targets for slices 1-3 (#171) #172

mathias referenced this issue