mathias/hyperguild
1
0
Fork 0
Code Issues 30 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

chore: verify brain injection wired in all four routing skill handlers #32

New Issue
Closed
opened 2026-05-28 10:31:55 +00:00 by mathias · 1 comment
mathias commented 2026-05-28 10:31:55 +00:00
Owner
Copy Link
Copy Source

Context

internal/skills/review/handlers.go calls brain.Query(ctx, ...) before dispatching to the LLM — confirmed in code review (2026-05-28). This was the top priority from the April 2026 scope reset ("brain_query injection into skill handlers").

Status of the other three skill handlers is unverified.

Task

Audit debug, retrospective, and trainer handlers against the reference pattern in review/handlers.go:

brainCtx, _ := brain.Query(ctx, s.cfg.IngestBaseURL, <relevant query>, 3)
// ...
if brainCtx != "" {
    task = brainCtx + "\n---\n\n" + task
}

For each handler:

  • internal/skills/debug/handlers.go — brain injection present?
  • internal/skills/retrospective/handlers.go — brain injection present?
  • internal/skills/trainer/handlers.go — brain injection present? (may not be applicable)

If missing, add using review as the reference. The query string should be derived from the skill's primary input (e.g. for debug: file path + error message; for retrospective: session_id + project_root).

Acceptance criteria

  • All three handlers audited
  • Any missing injection added and tested
  • task check passes

Notes

  • brain.Query signature: func Query(ctx context.Context, baseURL, query string, limit int) (string, error)
  • IngestBaseURL is in Config for all skill packages (matches review pattern)
  • Failure is silent (error ignored with _) — intentional, brain unavailability should not block skill execution
## Context `internal/skills/review/handlers.go` calls `brain.Query(ctx, ...)` before dispatching to the LLM — confirmed in code review (2026-05-28). This was the top priority from the April 2026 scope reset ("brain_query injection into skill handlers"). Status of the other three skill handlers is **unverified**. ## Task Audit `debug`, `retrospective`, and `trainer` handlers against the reference pattern in `review/handlers.go`: ```go brainCtx, _ := brain.Query(ctx, s.cfg.IngestBaseURL, <relevant query>, 3) // ... if brainCtx != "" { task = brainCtx + "\n---\n\n" + task } ``` For each handler: - [ ] `internal/skills/debug/handlers.go` — brain injection present? - [ ] `internal/skills/retrospective/handlers.go` — brain injection present? - [ ] `internal/skills/trainer/handlers.go` — brain injection present? (may not be applicable) If missing, add using review as the reference. The query string should be derived from the skill's primary input (e.g. for debug: file path + error message; for retrospective: session_id + project_root). ## Acceptance criteria - [ ] All three handlers audited - [ ] Any missing injection added and tested - [ ] `task check` passes ## Notes - `brain.Query` signature: `func Query(ctx context.Context, baseURL, query string, limit int) (string, error)` - `IngestBaseURL` is in `Config` for all skill packages (matches review pattern) - Failure is silent (error ignored with `_`) — intentional, brain unavailability should not block skill execution
mathias commented 2026-08-19 18:19:21 +00:00
Author
Owner
Copy Link
Copy Source

Obsolete per #75 (closed 2026-08-19): all four target handlers (internal/skills/{review,debug,retrospective,trainer}/handlers.go) are iceboxed, not part of the live tree — recoverable at tag icebox/cmd-routing-2026-07-01, per ICEBOX.md. Nothing to audit or fix in production. internal/skills/{brain,org,sessionlog}/ remain live but were never in this issue's scope. Closing as obsolete. Cascade re-triage per hyperguild#75, 2026-08-19.

Obsolete per #75 (closed 2026-08-19): all four target handlers (`internal/skills/{review,debug,retrospective,trainer}/handlers.go`) are iceboxed, not part of the live tree — recoverable at tag `icebox/cmd-routing-2026-07-01`, per `ICEBOX.md`. Nothing to audit or fix in production. `internal/skills/{brain,org,sessionlog}/` remain live but were never in this issue's scope. Closing as obsolete. Cascade re-triage per hyperguild#75, 2026-08-19.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agent/ready
Meets the agent-ready contract; authorizes unattended execution
 blocked/client
Waiting on the client
 blocked/supplier
Waiting on a supplier
 blocked/upstream
Waiting on an upstream project or vendor
 risk/high
Irreversible, security-relevant, or control plane
 risk/low
Reversible, local, test-covered
 risk/medium
Touches shared state, deploys or data
 size/l
Too big - split it
 size/m
Under two days
 size/s
Under half a day
 size/xs
Under an hour
 status:dispatch
status:dispatched
status:review
status:reviewing
type/chore
Maintenance, no behaviour change
 type/decision
Human decision required; never agent/ready
 type/docs
Documentation only
 type/feat
New capability
 type/fix
Corrects broken behaviour
 type/ops
Infrastructure, deploy, runtime
 type/research
Investigate; output is a finding, not code
 type/test
Test coverage only
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
renovate-bot mathias
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mathias/hyperguild#32