mathiasandClaude Sonnet 5
43f43e4621
Third review round on PR #126. Two real bugs in the rewrite from the previous commit: 1. The comment guard the sibling api package's frontmatter parser has (strings.HasPrefix(trimmed, "#")) was dropped in this reimplementation. A frontmatter comment containing a colon got cut at the colon and re-rendered with collapsed internal whitespace. 2. Worse: an indented YAML block-list item containing a colon (e.g. a title with a subtitle inside an aliases: list) was misparsed as a top-level key/value pair -- strings.Cut doesn't know a line is a continuation just because TrimSpace(key) happens to be non-empty. Re-rendering then stripped the line's indentation, de-indenting it out of the list it belonged to. refreshOwned re-renders this block on essentially every non-skipped ingest, so this was the normal path, not an edge case. Checked whether the sibling api/frontmatter.go has the same list-item gap: it does (same strings.Cut-then-TrimSpace shape, no indentation check) -- not a regression introduced here, a pre-existing latent defect shared with the package this was modeled on. Filed separately rather than fixed here (out of scope for this PR, needs its own review). Fixed by checking indentation BEFORE calling Cut at all -- a line starting with a space or tab is a continuation line, full stop, regardless of what it contains -- and restoring the comment guard verbatim from the sibling. Flip-tested both guards independently: removing either one turns its corresponding new test red in isolation; the other stays green, confirming they're independent fixes, not one masking the other. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>