mathiasandClaude Opus 5.5 66b6cf8a77 fix(brainfs): refuse a symlinked walk root (#157) ...

Review round 1 on PR #166: fs.WalkDir stats its root with a follow, and
os.Root allows a symlink that stays inside the brain, so knowledge -> .
aliased raw/, sessions/ and root files into the embeddings (and a
wiki/<w> -> .. root into search results). On main, filepath.WalkDir
Lstat'ed the root and did not descend.

- WalkRegular Lstats its root and requires a real directory; anything
  else goes to onErr as ErrNotRegular and nothing is yielded.
- Sync skips a missing scan root via bfs.Lstat before walking, and every
  other walk error, including a symlinked root, aborts before the delete
  pass. This removes the unpinned rel == sub special case.
- Search warns and skips a symlinked root (new test).
- Test renamed to TestSyncRefusesSymlinkedNotesAndSurvivesSwapRaces.
- wrapAfterStat comment: brainfs tests must not use t.Parallel.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-04 08:11:16 +02:00

..

brainfstest

fix(brain): context, brain_get and brain_read read through brainfs (#157, slice 2) (#165)

2026-10-04 05:59:55 +00:00

brainfs_test.go

fix(brainfs): refuse a symlinked walk root (#157)

2026-10-04 08:11:16 +02:00

brainfs.go

fix(brainfs): refuse a symlinked walk root (#157)

2026-10-04 08:11:16 +02:00