mathiasandClaude Sonnet 5.5
006a891423
From the independent review of #207: - parked notes are created O_EXCL with -2,-3 suffixes (same-named notes from different subfolders were overwritten and their originals deleted) - proposed_wing is emitted only if a plain wing name; a note's own proposal_* keys are dropped so they cannot outrank the resolver's (first-wins reads) - CRLF notes: wing: key honoured, one valid frontmatter block on parking - KnownWings skips wiki dirs that are not canonical lower-case names - adds the wingmigrate dry-run/apply command Each fix has a test that failed first and a mutant that fails it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
43 lines
1.6 KiB
Go
43 lines
1.6 KiB
Go
package wing_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mathiasbq/hyperguild/ingestion/internal/wing"
|
|
)
|
|
|
|
func TestKnownWings_ListsWingsWithHallsAndSkipsTheRetiredLayout(t *testing.T) {
|
|
dir := t.TempDir()
|
|
writePage(t, dir, "wiki/homelab/facts/a.md", "x")
|
|
writePage(t, dir, "wiki/tapir/decisions/b.md", "x")
|
|
writePage(t, dir, "wiki/concepts/c.md", "x") // retired layout, a file directly under a legacy dir
|
|
writePage(t, dir, "wiki/sources/d.md", "x") // retired layout
|
|
writePage(t, dir, "wiki/entities/e.md", "x") // retired layout
|
|
writePage(t, dir, "wiki/loose-note.md", "x") // a file, not a wing
|
|
writePage(t, dir, "wiki/emptywing/_index.md", "x") // a dir with no hall subdirectory
|
|
got, err := wing.KnownWings(dir)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, []string{"homelab", "tapir"}, got)
|
|
}
|
|
|
|
func TestKnownWings_NoWikiDirIsAnError(t *testing.T) {
|
|
_, err := wing.KnownWings(t.TempDir())
|
|
assert.Error(t, err, "a brain without wiki/ must not look like a brain with no wings")
|
|
}
|
|
|
|
// Known matches case-insensitively and the pipeline writes the lower-case name,
|
|
// so a wiki directory that is not already plain lower-case would make the
|
|
// pipeline create a different, new wing. It is not a candidate.
|
|
func TestKnownWings_SkipsADirectoryThatIsNotAPlainWingName(t *testing.T) {
|
|
dir := t.TempDir()
|
|
writePage(t, dir, "wiki/Radar/facts/a.md", "x")
|
|
writePage(t, dir, "wiki/has space/facts/a.md", "x")
|
|
writePage(t, dir, "wiki/ok/facts/a.md", "x")
|
|
got, err := wing.KnownWings(dir)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, []string{"ok"}, got)
|
|
}
|