Cross-link code-review trio + grill-me→stage-gate-review; strip false CLAUDE.md citation in receiving-code-review #16

Closed
opened 2026-07-25 20:47:04 +00:00 by mathias · 1 comment
Owner

Overlap audit (fork, 2026-07-25) confirmed these are correctly distinct, not duplicates — action is cross-referencing only, no merge:

  1. code-review (what to check, Go checklist) / superpowers-requesting-code-review (when/how to invoke a reviewer) / superpowers-receiving-code-review (how to behave when feedback arrives) — orthogonal concerns, similarly-named. Add one-line cross-refs between all three so an agent landing on one knows the others exist.
  2. grill-me (solo plan-sharpening technique, any scale) → stage-gate-review (formal council governance) — add a pointer from stage-gate-review's gate-prep step: "load grill-me Full Grill before bringing the ask."
  3. Bug, not just cross-link: superpowers-receiving-code-review cites "(explicit CLAUDE.md violation)" for the phrase "You're absolutely right!" — that's obra's own upstream CLAUDE.md convention leaking into the vendored copy, not Mathias's actual ~/dev/CLAUDE.md. Strip the false citation (the underlying anti-performative-agreement guidance is fine, just the citation is wrong).
Overlap audit (fork, 2026-07-25) confirmed these are correctly distinct, not duplicates — action is cross-referencing only, no merge: 1. `code-review` (what to check, Go checklist) / `superpowers-requesting-code-review` (when/how to invoke a reviewer) / `superpowers-receiving-code-review` (how to behave when feedback arrives) — orthogonal concerns, similarly-named. Add one-line cross-refs between all three so an agent landing on one knows the others exist. 2. `grill-me` (solo plan-sharpening technique, any scale) → `stage-gate-review` (formal council governance) — add a pointer from stage-gate-review's gate-prep step: "load grill-me Full Grill before bringing the ask." 3. **Bug, not just cross-link:** `superpowers-receiving-code-review` cites `"(explicit CLAUDE.md violation)"` for the phrase "You're absolutely right!" — that's obra's own upstream CLAUDE.md convention leaking into the vendored copy, not Mathias's actual `~/dev/CLAUDE.md`. Strip the false citation (the underlying anti-performative-agreement guidance is fine, just the citation is wrong).
mathias added the risk/lowsize/xstype/docs labels 2026-08-27 05:25:45 +00:00
Author
Owner

Done in e12ac99 — CI run #37 green.

All three items:

  1. Trio cross-linked. One line in each, placed at the core-principle line where a reader is already oriented rather than appended at the bottom: code-review is what to check, superpowers-requesting-code-review is how to commission a reviewer, superpowers-receiving-code-review is how to behave when the feedback arrives.
  2. stage-gate-review → grill-me. Added as step 5 of "Preparing an ask": load Full Grill before bringing it, because a council's hard questions are cheaper answered in private, and a gap found by grilling is one you close rather than one the gate reports.
  3. False citation stripped. Verified before removing rather than taking the report at face value:
$ grep -ci "absolutely right" ~/dev/CLAUDE.md ~/dev/.context/AGENT.md
0
0

The line now reads (performative agreement, not evaluation). The guidance was always right; the citation was inventing authority it did not have, which is worse than no citation — an agent that checks CLAUDE.md and finds nothing has reason to discount the whole rule.

Noticed while in there, not fixed

Every vendored superpowers-* skill has a frontmatter name: that disagrees with its directory: skills/superpowers-receiving-code-review/SKILL.md declares name: receiving-code-review. Harnesses that key on the directory and harnesses that key on the frontmatter will disagree about what this skill is called. Out of scope here and left alone; worth its own issue if it turns out to matter for invocation.

Done in `e12ac99` — CI run [#37](https://git.d-ma.be/mathias/skills/actions/runs/4854) green. All three items: 1. **Trio cross-linked.** One line in each, placed at the core-principle line where a reader is already oriented rather than appended at the bottom: `code-review` is what to check, `superpowers-requesting-code-review` is how to commission a reviewer, `superpowers-receiving-code-review` is how to behave when the feedback arrives. 2. **`stage-gate-review` → `grill-me`.** Added as step 5 of "Preparing an ask": load Full Grill before bringing it, because a council's hard questions are cheaper answered in private, and a gap found by grilling is one you close rather than one the gate reports. 3. **False citation stripped.** Verified before removing rather than taking the report at face value: ``` $ grep -ci "absolutely right" ~/dev/CLAUDE.md ~/dev/.context/AGENT.md 0 0 ``` The line now reads `(performative agreement, not evaluation)`. The guidance was always right; the citation was inventing authority it did not have, which is worse than no citation — an agent that checks CLAUDE.md and finds nothing has reason to discount the whole rule. ## Noticed while in there, not fixed Every vendored `superpowers-*` skill has a frontmatter `name:` that disagrees with its directory: `skills/superpowers-receiving-code-review/SKILL.md` declares `name: receiving-code-review`. Harnesses that key on the directory and harnesses that key on the frontmatter will disagree about what this skill is called. Out of scope here and left alone; worth its own issue if it turns out to matter for invocation.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mathias/skills#16