release / tag (push) Successful in 1s
The tagger searched the entire commit message for a bracketed marker as a substring. The commit that introduced the manifest-bump step described that marker in its own body — so the tagger read its own documentation as an instruction and skipped the release. Run 15 reported success with no tag, no manifest bump and no error. Same failure family as everything else in this sweep: the wrong thing happened silently. The rule is now a git trailer matched anchored to its own line, consistent with Bump-Type, and it lives in bin/should-skip-release rather than untested inside YAML. tests/release_skip_test.sh pins six cases, including the exact regression: a message that spells the marker out in prose must still tag. A marker you cannot mention without triggering is a footgun, not a mechanism. Bump-Type: patch Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeAp5LTscnz2W7Ubt4eJ6m
26 lines
839 B
Bash
Executable File
26 lines
839 B
Bash
Executable File
#!/bin/sh
|
|
# should-skip-release — reads a commit message on stdin. Exits 0 when the
|
|
# release tagger should skip this commit, 1 when it should tag.
|
|
#
|
|
# Skipping is opt-in via a git trailer:
|
|
#
|
|
# Skip-Release: true
|
|
#
|
|
# It is a TRAILER, matched anchored to its own line, deliberately. The first
|
|
# version searched the whole message for a bracketed marker as a substring,
|
|
# and the very commit that introduced the manifest-bump step described that
|
|
# marker in its body — so the tagger read its own documentation as an
|
|
# instruction and skipped the release. Success, no tag, no bump, no error
|
|
# (run 15, 2026-08-23). A marker you cannot mention without triggering is a
|
|
# footgun, not a mechanism.
|
|
|
|
set -u
|
|
|
|
msg=$(cat)
|
|
|
|
if printf '%s\n' "$msg" | grep -qiE '^[[:space:]]*Skip-Release:[[:space:]]*true[[:space:]]*$'; then
|
|
exit 0
|
|
fi
|
|
|
|
exit 1
|