From 471425cd4c05011c8f858558dbed7bb2aa8228ac Mon Sep 17 00:00:00 2001 From: Mathias Date: Fri, 2 Oct 2026 17:22:41 +0200 Subject: [PATCH] fix(cmd): the configured upload chat model is in the shared chat service's list, so it is no longer silently swapped (second review finding 2) Co-Authored-By: Claude Sonnet 5.5 --- cmd/tapir/processor.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/cmd/tapir/processor.go b/cmd/tapir/processor.go index c815262..980ddd4 100644 --- a/cmd/tapir/processor.go +++ b/cmd/tapir/processor.go @@ -134,6 +134,13 @@ func chatModels(cfg config.Config) []string { add(cfg.SummarizerModel) add(cfg.FallbackModel) add(cfg.CloudFallbackModel) + // The model chat over an uploaded recording opens on must be one the shared service can + // call: it re-maps a model it does not offer, which silently swapped a configured 31B for + // phi4-mini, whose context cannot hold an hour of speech. Local only, and only when + // uploads are on, so the video chat is unchanged otherwise (second adversarial review). + if cfg.UploadsEnabled && config.IsLocalModel(cfg.UploadChatModel) { + add(cfg.UploadChatModel) + } return models }