mathias/tapir
1
0
Fork 0
Code Issues 25 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(web): make /welcome a public path

Browse Source 
The landing page must render without a session. Add /welcome to
isPublicPath so the auth middleware lets it through (alongside /healthz
and /auth/*), and assert the bypass in the public-paths test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
mathias
2026-06-03 21:48:25 +02:00
co-authored by Claude Opus 4.8
parent 6b817f11b9
commit d83943c86a
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/web/oidc/oidc.go
+1 -1
View File
@@ -305,5 +305,5 @@ func (d *DexAuth) clearSessionCookie(w http.ResponseWriter) {
} }
func isPublicPath(p string) bool { func isPublicPath(p string) bool {
return p == "/healthz" || strings.HasPrefix(p, "/auth/") return p == "/healthz" || p == "/welcome" || strings.HasPrefix(p, "/auth/")
} }
internal/web/oidc/oidc_test.go
+1 -1
View File
@@ -280,7 +280,7 @@ func TestMiddlewarePublicPathsBypassAuth(t *testing.T) {
w.WriteHeader(http.StatusOK) w.WriteHeader(http.StatusOK)
})) }))
for _, path := range []string{"/healthz", "/auth/login"} { for _, path := range []string{"/healthz", "/welcome", "/auth/login"} {
rec := httptest.NewRecorder() rec := httptest.NewRecorder()
guarded.ServeHTTP(rec, httptest.NewRequest(http.MethodGet, path, nil)) guarded.ServeHTTP(rec, httptest.NewRequest(http.MethodGet, path, nil))
require.Equal(t, http.StatusOK, rec.Code, "expected %s to bypass auth", path) require.Equal(t, http.StatusOK, rec.Code, "expected %s to bypass auth", path)