From e9863c2e12e05d0995d3c87d27975a66b728d9fe Mon Sep 17 00:00:00 2001 From: Mathias Date: Fri, 2 Oct 2026 16:40:10 +0200 Subject: [PATCH] test(progress): a keyed failure logs its kind, not the error's text (red; review F3) Co-Authored-By: Claude Sonnet 5.5 --- internal/progress/tracker_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/progress/tracker_test.go b/internal/progress/tracker_test.go index cf78319..b3c231b 100644 --- a/internal/progress/tracker_test.go +++ b/internal/progress/tracker_test.go @@ -197,7 +197,7 @@ func TestTracker_FailRunningMarksTheRunningStepFailedAndLeavesTheRestPending(t * require.Equal(t, domain.StepPending, stateOf(steps, "save"), "what never started stays pending: it shows where the job stopped") } -func TestTracker_AKeyedFailMarksOneStepFailedLogsWhyAndTheJobGoesOn(t *testing.T) { +func TestTracker_AKeyedFailMarksOneStepFailedLogsItsKindAndTheJobGoesOn(t *testing.T) { tr, sink, _, buf := newTracker(t) tr.Start() tr.Begin("audio", 0) @@ -209,7 +209,8 @@ func TestTracker_AKeyedFailMarksOneStepFailedLogsWhyAndTheJobGoesOn(t *testing.T require.Equal(t, domain.StepFailed, stateOf(steps, "audio")) require.Equal(t, domain.StepRunning, stateOf(steps, "decide"), "a soft failure must not stop the next step from running") require.Contains(t, buf.String(), "level=WARN") - require.Contains(t, buf.String(), "gateway said no") + require.NotContains(t, buf.String(), "gateway said no", "an error's text can carry provider output or a path: the log gets its kind") + require.Contains(t, buf.String(), "kind=error") require.Contains(t, buf.String(), "step=audio") }