From the adversarial review of PR #55 (finding 7, low). serveHTTP (cmd/tapir/shutdown.go) discards the error from Shutdown(shutdownCtx), so a drain that hit its 10 s grace leaves no log line; and signal.NotifyContext's stop() only runs at exit, so a second SIGTERM/SIGINT during the grace period is swallowed (an operator pressing Ctrl-C twice cannot force a quit). Fix: log the Shutdown error with the server address; after the first signal call stop() (restoring default handling) so a second one terminates. Red tests: a handler that outlives the grace produces a warn line; a second signal ends the process. Milestone v0.32.0, risk/low.
From the adversarial review of PR #55 (finding 7, low). `serveHTTP` (`cmd/tapir/shutdown.go`) discards the error from `Shutdown(shutdownCtx)`, so a drain that hit its 10 s grace leaves no log line; and `signal.NotifyContext`'s `stop()` only runs at exit, so a second SIGTERM/SIGINT during the grace period is swallowed (an operator pressing Ctrl-C twice cannot force a quit). Fix: log the Shutdown error with the server address; after the first signal call `stop()` (restoring default handling) so a second one terminates. Red tests: a handler that outlives the grace produces a warn line; a second signal ends the process. Milestone v0.32.0, risk/low.
---
_Created via git-mcp on behalf of @mathias_
mathias
added this to the v0.32.0 - audio upload follow-ups milestone 2026-10-03 19:13:13 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
From the adversarial review of PR #55 (finding 7, low).
serveHTTP(cmd/tapir/shutdown.go) discards the error fromShutdown(shutdownCtx), so a drain that hit its 10 s grace leaves no log line; andsignal.NotifyContext'sstop()only runs at exit, so a second SIGTERM/SIGINT during the grace period is swallowed (an operator pressing Ctrl-C twice cannot force a quit). Fix: log the Shutdown error with the server address; after the first signal callstop()(restoring default handling) so a second one terminates. Red tests: a handler that outlives the grace produces a warn line; a second signal ends the process. Milestone v0.32.0, risk/low.Created via git-mcp on behalf of @mathias