mathias

mathias commented on issue mathias/hyperguild#157

2026-10-03 15:13:50 +00:00

SECURITY: symlinks anywhere in the Syncthing-shared brain dir are followed by search, vectorstore, context and graph readers

pr-gatekeeper verdict, round 2: BLOCK (PR #159 @ 956ad8b)

Not merged. CI run 8895 is green and CI=1 task check EXIT=0. -race -count=5 is also green. All of the round-1 findings are…

mathias commented on pull request mathias/hyperguild#159

2026-10-03 15:13:50 +00:00

feat(ingestion): symlink tripwire for the Syncthing-shared brain dir (#157)

pr-gatekeeper verdict, round 2: BLOCK (PR #159 @ 956ad8b)

Not merged. CI run 8895 is green and CI=1 task check EXIT=0. -race -count=5 is also green. All of the round-1 findings are…

mathias pushed to feat/symlink-tripwire-157 at mathias/hyperguild

2026-10-03 15:11:46 +00:00

956ad8b9fb fix(ingestion): close the PR #159 review findings on the symlink tripwire

mathias commented on issue mathias/hyperguild#157

2026-10-03 15:08:37 +00:00

SECURITY: symlinks anywhere in the Syncthing-shared brain dir are followed by search, vectorstore, context and graph readers

pr-gatekeeper verdict: BLOCK (PR #159 @ 796d226)

Not merged. CI run 8893 is green, CI=1 task check EXIT=0 locally, and neither covers any of the findings below.

Findings (most…

mathias commented on pull request mathias/hyperguild#159

2026-10-03 15:08:37 +00:00

feat(ingestion): symlink tripwire for the Syncthing-shared brain dir (#157)

pr-gatekeeper verdict: BLOCK (PR #159 @ 796d226)

Not merged. CI run 8893 is green, CI=1 task check EXIT=0 locally, and neither covers any of the findings below.

Findings (most…

mathias pushed to fix/raw-symlinks-153 at mathias/hyperguild

2026-10-03 15:07:59 +00:00

d5b2be0ecf test(ingestion): behavioural race tests for raw/ reads; tighten the lint

mathias commented on issue mathias/hyperguild#153

2026-10-03 15:05:05 +00:00

brain/raw/ readers follow symlinks (pending, promote); raw/ is writable via Syncthing

Gatekeeper round 3 on PR #156 (head 8094200): BLOCK. Details are on the PR.

The round-2 findings are fixed. New: the parser lint forbids Open/OpenFile but not ReadFile. Changing one…

mathias commented on pull request mathias/hyperguild#156

2026-10-03 15:05:04 +00:00

fix(ingestion): brain/raw/ readers go through an os.Root; symlinks are inert (#153)

Gatekeeper verdict, round 3: BLOCK (head 8094200)

Round-2 findings: fixed, verified by running them

Reverting readRawNote, TextIn or copyFromRoot to a plain Open now fails…

mathias created pull request mathias/hyperguild#159

2026-10-03 15:04:56 +00:00

feat(ingestion): symlink tripwire for the Syncthing-shared brain dir (#157)

mathias pushed to feat/symlink-tripwire-157 at mathias/hyperguild

2026-10-03 15:04:43 +00:00

796d226497 feat(ingestion): symlink tripwire for the Syncthing-shared brain dir

mathias created branch feat/symlink-tripwire-157 in mathias/hyperguild

2026-10-03 15:04:43 +00:00

mathias pushed to fix/raw-symlinks-153 at mathias/hyperguild

2026-10-03 15:03:10 +00:00

809420070b test(extract): enforce the raw/ open discipline with the Go parser

mathias commented on issue mathias/hyperguild#157

2026-10-03 15:02:04 +00:00

SECURITY: symlinks anywhere in the Syncthing-shared brain dir are followed by search, vectorstore, context and graph readers

Decision (Mathias, 2026-10-03): option 2 now as a tripwire, then option 1 (brain-wide readers through os.Root, skipping non-regular files). Option 3 (Syncthing) is not pursued.

_Created…

mathias commented on issue mathias/hyperguild#153

2026-10-03 15:01:42 +00:00

brain/raw/ readers follow symlinks (pending, promote); raw/ is writable via Syncthing

Gatekeeper round 2 on PR #156 (head 87c80e4): BLOCK. Details are on the PR.

Round-1 findings 1, 2, 3, 6 and 7 are fixed and verified by running them. The FIFO hang is gone under a race of…

mathias commented on pull request mathias/hyperguild#156

2026-10-03 15:01:41 +00:00

fix(ingestion): brain/raw/ readers go through an os.Root; symlinks are inert (#153)

Gatekeeper verdict, round 2: BLOCK (head 87c80e4)

Close. One finding has the same shape as round 1's finding 1. Each fix below was re-verified by running it, not by reading it.

Fixed,…

mathias pushed to fix/raw-symlinks-153 at mathias/hyperguild

2026-10-03 14:59:10 +00:00

87c80e4e82 fix(ingestion): close the PR #156 review findings on raw/ reads

mathias opened issue mathias/hyperguild#158

2026-10-03 14:57:17 +00:00

Writes under brain/raw/ follow symlinks: processed/, rejected/, .processed markers, tunnel-candidates

mathias opened issue mathias/hyperguild#157

2026-10-03 14:57:13 +00:00

SECURITY: symlinks anywhere in the Syncthing-shared brain dir are followed by search, vectorstore, context and graph readers

mathias commented on issue mathias/hyperguild#153

2026-10-03 14:57:02 +00:00

brain/raw/ readers follow symlinks (pending, promote); raw/ is writable via Syncthing

Correction: the premise of the item-2 decision above was false. I told Mathias that once raw/ readers are fixed, the Syncthing write path can't leak outside files. The PR #156 review showed…

mathias commented on issue mathias/hyperguild#153

2026-10-03 14:56:21 +00:00

brain/raw/ readers follow symlinks (pending, promote); raw/ is writable via Syncthing

Gatekeeper review of PR #156 (head 8a91feb): BLOCK. Full evidence is on the PR thread (mathias/hyperguild#156).

Summary: under execution the raw/ read control held.…