• Joined on 2026-03-27
mathias commented on issue mathias/hyperguild#123 2026-09-23 08:38:08 +00:00
Audit remaining write paths that reach disk without claim-envelope validation (brain_edit, ingestion pipeline)

Round 4 (PR #136, commit 110e8b8) correctly closes round 3's exact repro — an edit whose new_str drops the closing fence is now rejected via the new hadFence && !hasFence check. **Verdict:…

mathias pushed to fix/123-brain-edit-envelope-check at mathias/hyperguild 2026-09-23 08:32:47 +00:00
110e8b8f75 fix(mcp): reject edits that strip a note's frontmatter fence
mathias commented on issue mathias/hyperguild#123 2026-09-23 08:30:42 +00:00
Audit remaining write paths that reach disk without claim-envelope validation (brain_edit, ingestion pipeline)

Round 3 (PR #136, commit 0f932d8) closes both round-1 (field-name substring gate) and round-2 (block-containment gate) bypass classes by removing the gate entirely — checkClaimEnvelope now…

mathias pushed to fix/123-brain-edit-envelope-check at mathias/hyperguild 2026-09-23 08:27:31 +00:00
0f932d8f77 fix(mcp): drop the containment gate, always validate the post-edit envelope
mathias commented on issue mathias/hyperguild#123 2026-09-23 08:25:33 +00:00
Audit remaining write paths that reach disk without claim-envelope validation (brain_edit, ingestion pipeline)

Round 2 (PR #136, commit 062574d) closes round 1's field-name bypass but introduces a new, reproducible bypass in the same function. Verdict: not merged, blocking.

New bypass: old_str…

mathias pushed to fix/123-brain-edit-envelope-check at mathias/hyperguild 2026-09-23 08:21:54 +00:00
062574dad8 fix(mcp): close claim-envelope bypass on value-only brain_edit diffs
mathias commented on issue mathias/hyperguild#125 2026-09-23 08:18:51 +00:00
UpdateNote: supersede_reason settable via caller's own frontmatter fragment, bypassing the Reason option

Merged PR #137 (squash) as merge commit a5f502eb9c4bbe13b6720ccaf930d41f265a2d16.

Review evidence:

  • Diff: ingestion/internal/api/update.go's merge loop now skips l.key in `{"", "updated_at",…
mathias deleted branch fix/125-update-note-reserved-fields from mathias/hyperguild 2026-09-23 08:18:42 +00:00
mathias pushed to main at mathias/hyperguild 2026-09-23 08:18:31 +00:00
a5f502eb9c fix(api): UpdateNote reserves updated_at/supersedes/supersede_reason from the caller's fragment (#137)
mathias closed issue mathias/hyperguild#125 2026-09-23 08:18:30 +00:00
UpdateNote: supersede_reason settable via caller's own frontmatter fragment, bypassing the Reason option
mathias merged pull request mathias/hyperguild#137 2026-09-23 08:18:30 +00:00
fix(api): UpdateNote reserves updated_at/supersedes/supersede_reason from the caller's fragment
mathias created pull request mathias/hyperguild#137 2026-09-23 08:16:33 +00:00
fix(api): UpdateNote reserves updated_at/supersedes/supersede_reason from the caller's fragment
mathias pushed to fix/125-update-note-reserved-fields at mathias/hyperguild 2026-09-23 08:16:27 +00:00
fb69f4bf3d fix(api): UpdateNote reserves updated_at/supersedes/supersede_reason from the caller's fragment
mathias created branch fix/125-update-note-reserved-fields in mathias/hyperguild 2026-09-23 08:16:27 +00:00
mathias created pull request mathias/hyperguild#136 2026-09-23 08:14:18 +00:00
fix(mcp): validate the claim envelope before brain_edit writes too
mathias pushed to fix/123-brain-edit-envelope-check at mathias/hyperguild 2026-09-23 08:14:10 +00:00
f7fe00cecf fix(mcp): validate the claim envelope before brain_edit writes too
mathias created branch fix/123-brain-edit-envelope-check in mathias/hyperguild 2026-09-23 08:14:10 +00:00
mathias deleted branch fix/128-frontmatter-indented-lines from mathias/hyperguild 2026-09-23 08:12:36 +00:00
mathias commented on issue mathias/hyperguild#128 2026-09-23 08:12:27 +00:00
api/frontmatter.go's parseFrontmatter misparses an indented list item containing a colon as a top-level key

Reviewed and merged as PR #135, squash commit 7ed2a7d3b4996db795fee3a7a38487f104612f83 (head 695e90257ad8a0e1f3573919903715d80d10d9db).

Verification performed:

  • Flip-tested both fixes independent…
mathias pushed to main at mathias/hyperguild 2026-09-23 08:12:07 +00:00
7ed2a7d3b4 fix(api): frontmatter parser must not misparse indented list items as keys (#135)