• Joined on 2026-03-27
mathias merged pull request mathias/hyperguild#132 2026-09-23 05:45:47 +00:00
feat(pipeline): feed the current source page into the extraction prompt (#106)
mathias deleted branch chore/79-remove-brain-write-legacy-params from mathias/hyperguild 2026-09-23 05:44:02 +00:00
mathias commented on issue mathias/hyperguild#79 2026-09-23 05:43:58 +00:00
chore(brain): deprecate + remove brain_write legacy params (domain/type/knowledge-path) (ADR-0012)

Merged PR #131 (squash) at commit f324f04944ea842b09e6dd8f492aa970511b9ec3, head 975b61c.

Re-review of the fix (975b61c) that addressed the earlier BLOCK:

  • cmd/hyperguild brain write is…
mathias pushed to feat/106-page-aware-extraction-v2 at mathias/hyperguild 2026-09-23 05:43:55 +00:00
bdba49b756 fix(wiki): pair duplicate-heading occurrences positionally, not all to one index
mathias pushed to main at mathias/hyperguild 2026-09-23 05:43:30 +00:00
f324f04944 fix: hyperguild brain write requires wing/hall, not legacy type/slug (#79)
mathias merged pull request mathias/hyperguild#131 2026-09-23 05:43:28 +00:00
chore(brain): remove brain_write legacy params domain/type/knowledge-path (ADR-0012)
mathias closed issue mathias/hyperguild#79 2026-09-23 05:43:28 +00:00
chore(brain): deprecate + remove brain_write legacy params (domain/type/knowledge-path) (ADR-0012)
mathias commented on issue mathias/hyperguild#106 2026-09-23 05:42:01 +00:00
Compile-on-ingest, second half: let the extraction see the page it is revising

Review of PR #132 — NOT merged, blocking finding

Rebase mechanics: clean. origin/main HEAD is cdafdf6 (#104's merge commit), exactly the PR's merge-base — no drift since opening.…

mathias commented on pull request mathias/hyperguild#131 2026-09-23 05:40:28 +00:00
chore(brain): remove brain_write legacy params domain/type/knowledge-path (ADR-0012)

Fixed the regression found in review (commit 975b61c, pushed on top of this PR's branch).

Root cause (recap): WriteNote's legacy brain/knowledge/ fallback (activated when wing/hall were…

mathias pushed to chore/79-remove-brain-write-legacy-params at mathias/hyperguild 2026-09-23 05:40:18 +00:00
975b61c9d7 fix: hyperguild brain write requires wing/hall, not legacy type/slug
mathias closed pull request mathias/hyperguild#130 2026-09-23 05:39:01 +00:00
feat(pipeline): page-aware extraction — feed the current page into the revision prompt
mathias commented on pull request mathias/hyperguild#130 2026-09-23 05:38:59 +00:00
feat(pipeline): page-aware extraction — feed the current page into the revision prompt

Superseded by #132: same 3 commits, rebased onto current main so the collision fix lands in wiki.MergeReport (the function production actually calls after #104's split) instead of the now-vestigi…

mathias created pull request mathias/hyperguild#132 2026-09-23 05:38:56 +00:00
feat(pipeline): feed the current source page into the extraction prompt (#106)
mathias pushed to feat/106-page-aware-extraction-v2 at mathias/hyperguild 2026-09-23 05:38:49 +00:00
921bea8738 fix(wiki): first-occurrence wins when heading normalization collides pre-existing duplicates
bf935d89bf fix(wiki): normalise heading casing/whitespace before matching in Merge
6e83303752 feat(pipeline): feed the current source page into the extraction prompt
Compare 3 commits »
mathias created branch feat/106-page-aware-extraction-v2 in mathias/hyperguild 2026-09-23 05:38:49 +00:00
mathias commented on issue mathias/hyperguild#79 2026-09-23 05:35:59 +00:00
chore(brain): deprecate + remove brain_write legacy params (domain/type/knowledge-path) (ADR-0012)

Review verdict: BLOCKED (not merged). PR #131, head e8e2338.

Verified independently:

  • Re-grepped for WriteNoteOptions.Type/.Domain, writeLegacyNote, remaining knowledge/ write-path…
mathias pushed to feat/106-page-aware-extraction at mathias/hyperguild 2026-09-23 05:34:53 +00:00
28d9f40733 fix(wiki): first-occurrence wins when heading normalization collides pre-existing duplicates
mathias created pull request mathias/hyperguild#131 2026-09-23 05:32:46 +00:00
chore(brain): remove brain_write legacy params domain/type/knowledge-path (ADR-0012)
mathias commented on issue mathias/hyperguild#106 2026-09-23 05:32:38 +00:00
Compile-on-ingest, second half: let the extraction see the page it is revising

Review of PR #130 (feat/106-page-aware-extraction) — BLOCKED, not merged

What's solid: BuildPrompt's existing-page plumbing is real (empty string confirmed on a fresh source, non-empty…

mathias pushed to chore/79-remove-brain-write-legacy-params at mathias/hyperguild 2026-09-23 05:32:30 +00:00
e8e233823d chore(brain): remove brain_write legacy params domain/type/knowledge-path (ADR-0012)