generated from mathias/template-go-web
mathiasandClaude Opus 5
097d8747c6
Adds the repos panel from #4's "Not yet shipped" list, following the shipped
issues slice (b2761a4) structurally rather than inventing a second approach:
- internal/atlas/repos.go — RepoNodes(), a pure parser over an already-decoded
/user/repos response. Archived repos are dropped: the atlas shows where work
happens, and an archived repo is by definition somewhere it does not.
- internal/gitea/client.go — MyRepos(), same PAT and same contract as MyIssues:
errors when GITEA_TOKEN is unset so the caller skips the overlay rather than
issuing an unauthenticated request. That unset path is the one running in
prod today (#4), so it is tested, not assumed.
- internal/web/handler.go — wired into liveOverlay().
Stage 05 is the right home — repos are what the execution stage acts on — but
#11 had just claimed its `generate` key for stuck-badges, and a stage could
only name one source. So `generate` now accepts either spelling:
"generate": "ci-jobs"
"generate": ["stuck-badges", "gitea-repos"]
The bare string stays valid and marshals back as a bare string, so no authored
stage is rewritten and the frontend contract is unchanged. Stages 04 and 08
already share stuck-badges between them; this is the same growth one level in.
The overlay merge also moves out of the handler into atlas.PrependGenerated,
which is unit-testable where the inline loop was not — it sat behind a network
call. It covers the issues path too, and fixes a latent aliasing bug there: the
old `append(liveNodes, authored...)` wrote into the live slice's backing array,
so two stages sharing a key would corrupt each other. That shape is no longer
hypothetical now that stuck-badges spans three stages.
Verified end-to-end both ways: without GITEA_TOKEN the atlas returns 200 with
stage 05's authored nodes intact; with a real token stage 05 serves both
overlays at once — stuck badges, then eight live repos, then the authored
nodes — and a repo with no language emits one tag rather than an empty pill.
task check green (golangci-lint 0 issues, vet, -race).
Closes #10.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
89 lines
2.7 KiB
Go
89 lines
2.7 KiB
Go
package atlas_test
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"git.d-ma.be/mathias/cad-atlas/internal/atlas"
|
|
)
|
|
|
|
func TestBuild_OverlaysCIStageNodesFromWorkflow(t *testing.T) {
|
|
atlasJSON := []byte(`{
|
|
"substrate": [{"n":"koala","k":"gpu"}],
|
|
"stages": [
|
|
{"no":"STAGE 06","title":"PR → CI","generate":"ci-jobs","nodes":[]},
|
|
{"no":"STAGE 01","title":"TELOS","nodes":[{"t":"Intention substrate"}]}
|
|
]}`)
|
|
workflow := []byte("jobs:\n check:\n a: 1\n build:\n b: 2\n deploy:\n c: 3\n")
|
|
|
|
a, err := atlas.Build(atlasJSON, workflow)
|
|
if err != nil {
|
|
t.Fatalf("Build: %v", err)
|
|
}
|
|
|
|
// CI stage nodes generated from the workflow's jobs, in order.
|
|
var titles []string
|
|
for _, n := range a.Stages[0].Nodes {
|
|
titles = append(titles, n.Title)
|
|
}
|
|
if want := []string{"check", "build", "deploy"}; !reflect.DeepEqual(titles, want) {
|
|
t.Fatalf("CI stage nodes = %v, want %v", titles, want)
|
|
}
|
|
|
|
// Non-generated stage is untouched.
|
|
if a.Stages[1].Nodes[0].Title != "Intention substrate" {
|
|
t.Fatalf("authored stage was altered: %+v", a.Stages[1])
|
|
}
|
|
|
|
// Substrate preserved.
|
|
if len(a.Substrate) != 1 || a.Substrate[0].Name != "koala" {
|
|
t.Fatalf("substrate not preserved: %+v", a.Substrate)
|
|
}
|
|
}
|
|
|
|
func TestDefault_HasPlainLayerAndTransitions(t *testing.T) {
|
|
a, err := atlas.Build(atlas.DataJSON, []byte("jobs:\n guard:\n a: 1\n"))
|
|
if err != nil {
|
|
t.Fatalf("Build embedded atlas: %v", err)
|
|
}
|
|
for _, s := range a.Stages {
|
|
if s.PlainTitle == "" {
|
|
t.Fatalf("stage %s missing plain_title", s.No)
|
|
}
|
|
if s.TransLabel == "" {
|
|
t.Fatalf("stage %s missing trans_label", s.No)
|
|
}
|
|
if s.Generate.Has("ci-jobs") {
|
|
continue // nodes are generated live, no authored plain
|
|
}
|
|
for _, n := range s.Nodes {
|
|
if n.Plain == "" {
|
|
t.Fatalf("stage %s node %q missing plain", s.No, n.Title)
|
|
}
|
|
if n.PlainTitle == "" {
|
|
t.Fatalf("stage %s node %q missing plain_t", s.No, n.Title)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBuild_KeepsCIPlaceholderWhenNoJobs(t *testing.T) {
|
|
atlasJSON := []byte(`{"substrate":[],"stages":[
|
|
{"no":"STAGE 06","title":"PR → CI","generate":"ci-jobs","nodes":[{"t":"Automated checks","plain":"checks run here"}]}
|
|
]}`)
|
|
// A workflow with no jobs block must NOT error and must keep the placeholder.
|
|
a, err := atlas.Build(atlasJSON, []byte("name: cd\n"))
|
|
if err != nil {
|
|
t.Fatalf("Build should tolerate a no-jobs workflow, got: %v", err)
|
|
}
|
|
if len(a.Stages[0].Nodes) != 1 || a.Stages[0].Nodes[0].Title != "Automated checks" {
|
|
t.Fatalf("placeholder not kept: %+v", a.Stages[0].Nodes)
|
|
}
|
|
}
|
|
|
|
func TestBuild_ErrorsOnBadAtlasJSON(t *testing.T) {
|
|
if _, err := atlas.Build([]byte("{not json"), []byte("jobs:\n x:\n a: 1\n")); err == nil {
|
|
t.Fatal("expected error on bad atlas JSON, got nil")
|
|
}
|
|
}
|