generated from mathias/template-go-web
mathiasandClaude Opus 4.8
863c4c964b
Lap-2 review's top two findings: #1 Node titles were still jargon (the lap-1 disease one level down). Every node now has a plain_t ("var-go Oath" → "Definition of done", "Admission controller" → "Tamper-proof seal", …); Plain view leads with it and demotes the technical name to a dim in-card subtitle — mirrors the stage-head pattern. plain_t on every authored node is now guard-tested. #2 Transition labels lived only in the SVG spine (display:none <820px) with a hover-only rationale — invisible on phones. Added stacked-layout transition rows (HTML, always-visible, full sentence, no hover) shown on mobile; desktop header band scoped to ≥821px so mobile isn't stretched. build/vet/lint(0)/test green; desktop Plain screenshot-verified. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
89 lines
2.7 KiB
Go
89 lines
2.7 KiB
Go
package atlas_test
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"git.d-ma.be/mathias/cad-atlas/internal/atlas"
|
|
)
|
|
|
|
func TestBuild_OverlaysCIStageNodesFromWorkflow(t *testing.T) {
|
|
atlasJSON := []byte(`{
|
|
"substrate": [{"n":"koala","k":"gpu"}],
|
|
"stages": [
|
|
{"no":"STAGE 06","title":"PR → CI","generate":"ci-jobs","nodes":[]},
|
|
{"no":"STAGE 01","title":"TELOS","nodes":[{"t":"Intention substrate"}]}
|
|
]}`)
|
|
workflow := []byte("jobs:\n check:\n a: 1\n build:\n b: 2\n deploy:\n c: 3\n")
|
|
|
|
a, err := atlas.Build(atlasJSON, workflow)
|
|
if err != nil {
|
|
t.Fatalf("Build: %v", err)
|
|
}
|
|
|
|
// CI stage nodes generated from the workflow's jobs, in order.
|
|
var titles []string
|
|
for _, n := range a.Stages[0].Nodes {
|
|
titles = append(titles, n.Title)
|
|
}
|
|
if want := []string{"check", "build", "deploy"}; !reflect.DeepEqual(titles, want) {
|
|
t.Fatalf("CI stage nodes = %v, want %v", titles, want)
|
|
}
|
|
|
|
// Non-generated stage is untouched.
|
|
if a.Stages[1].Nodes[0].Title != "Intention substrate" {
|
|
t.Fatalf("authored stage was altered: %+v", a.Stages[1])
|
|
}
|
|
|
|
// Substrate preserved.
|
|
if len(a.Substrate) != 1 || a.Substrate[0].Name != "koala" {
|
|
t.Fatalf("substrate not preserved: %+v", a.Substrate)
|
|
}
|
|
}
|
|
|
|
func TestDefault_HasPlainLayerAndTransitions(t *testing.T) {
|
|
a, err := atlas.Build(atlas.DataJSON, []byte("jobs:\n guard:\n a: 1\n"))
|
|
if err != nil {
|
|
t.Fatalf("Build embedded atlas: %v", err)
|
|
}
|
|
for _, s := range a.Stages {
|
|
if s.PlainTitle == "" {
|
|
t.Fatalf("stage %s missing plain_title", s.No)
|
|
}
|
|
if s.TransLabel == "" {
|
|
t.Fatalf("stage %s missing trans_label", s.No)
|
|
}
|
|
if s.Generate == "ci-jobs" {
|
|
continue // nodes are generated live, no authored plain
|
|
}
|
|
for _, n := range s.Nodes {
|
|
if n.Plain == "" {
|
|
t.Fatalf("stage %s node %q missing plain", s.No, n.Title)
|
|
}
|
|
if n.PlainTitle == "" {
|
|
t.Fatalf("stage %s node %q missing plain_t", s.No, n.Title)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBuild_KeepsCIPlaceholderWhenNoJobs(t *testing.T) {
|
|
atlasJSON := []byte(`{"substrate":[],"stages":[
|
|
{"no":"STAGE 06","title":"PR → CI","generate":"ci-jobs","nodes":[{"t":"Automated checks","plain":"checks run here"}]}
|
|
]}`)
|
|
// A workflow with no jobs block must NOT error and must keep the placeholder.
|
|
a, err := atlas.Build(atlasJSON, []byte("name: cd\n"))
|
|
if err != nil {
|
|
t.Fatalf("Build should tolerate a no-jobs workflow, got: %v", err)
|
|
}
|
|
if len(a.Stages[0].Nodes) != 1 || a.Stages[0].Nodes[0].Title != "Automated checks" {
|
|
t.Fatalf("placeholder not kept: %+v", a.Stages[0].Nodes)
|
|
}
|
|
}
|
|
|
|
func TestBuild_ErrorsOnBadAtlasJSON(t *testing.T) {
|
|
if _, err := atlas.Build([]byte("{not json"), []byte("jobs:\n x:\n a: 1\n")); err == nil {
|
|
t.Fatal("expected error on bad atlas JSON, got nil")
|
|
}
|
|
}
|