Files
mathiasandClaude Sonnet 5 43714047be
CD / Lint / Test / Vet (push) Successful in 9s
CD / Build & Import (push) Successful in 25s
CD / Deploy via GitOps (push) Has been skipped
fix(auth): owner allowlist trusts pass-through-authenticated callers (#59)
Allowlist.Check now takes ctx: when the caller authenticated with
their own Gitea PAT (pass-through, v0.12.0), it skips the static
GITEA_MCP_ALLOWED_OWNERS check entirely — Gitea's own permission
model already gates that caller's access more precisely than a coarse
owner-name list can. The static list still applies unchanged for the
shared static-token/JWT path, where it's the only defense against the
service token's blast radius.

Mechanical: every tool call site already had ctx in scope, so this is
a signature-only change at 41 call sites, no other tool behavior
changes. Closes the "Deferred" item from #59.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-22 08:31:43 +02:00

68 lines
1.5 KiB
Go

package tools
import (
"context"
"encoding/json"
"git.d-ma.be/mathias/gitea-mcp/internal/allowlist"
"git.d-ma.be/mathias/gitea-mcp/internal/gitea"
"git.d-ma.be/mathias/gitea-mcp/internal/registry"
)
type BranchList struct {
c *gitea.Client
a *allowlist.Allowlist
}
func NewBranchList(c *gitea.Client, a *allowlist.Allowlist) *BranchList {
return &BranchList{c: c, a: a}
}
func (t *BranchList) Descriptor() registry.ToolDescriptor {
return registry.ToolDescriptor{
Name: "branch_list",
Description: "List branches in a repository.",
InputSchema: json.RawMessage(`{
"type":"object",
"properties":{
"owner":{"type":"string"},
"repo":{"type":"string"},
"page":{"type":"integer","minimum":1},
"limit":{"type":"integer","minimum":1,"maximum":50}
},
"required":["owner","repo"]
}`),
}
}
type branchListArgs struct {
Owner string `json:"owner"`
Repo string `json:"repo"`
Page int `json:"page"`
Limit int `json:"limit"`
}
func (t *BranchList) Call(ctx context.Context, raw json.RawMessage) (json.RawMessage, error) {
var args branchListArgs
if err := parseArgs(raw, &args); err != nil {
return nil, err
}
if err := t.a.Check(ctx, args.Owner); err != nil {
return nil, err
}
branches, err := t.c.ListBranches(ctx, args.Owner, args.Repo, args.Page, capLimit(args.Limit, 30))
if err != nil {
return nil, err
}
result := make([]map[string]any, len(branches))
for i, b := range branches {
result[i] = map[string]any{
"name": b.Name,
"sha": b.Commit.ID,
}
}
return textOK(result)
}