mathiasandClaude Opus 4.8
93c32edbb5
Every caller (claude.ai connector, LLMs primed on gitea/GitHub) sends the repo identifier as `repo`, but the 33 per-repo identifier tools advertised `name`. The v0.2.8 shim aliased repo->name so it worked, yet the advertised inputSchema still said `name` — a misleading contract, with the shim load-bearing. - Flip all 33 identifier tools: schema property + required + struct field/tag from `name` to `repo`. A compliant `repo` caller now matches the struct directly; the shim is pure back-compat. - normalizeAliases is now bidirectional (name<->repo), so legacy `name` callers still resolve, and repo_create / create_project_from_template — whose `name` means "name of the NEW repo", not an existing-repo id — keep `name` and still accept `repo`. - `number`/`index` left as-is (out of scope; separate pre-existing quirk where pr_merge advertises `index` rather than `number`). - Tests: schema-canonical assertion + flipped alias round-trip (explicit `repo` wins over `name`). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
92 lines
3.0 KiB
Go
92 lines
3.0 KiB
Go
package tools
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
|
|
"gitea.d-ma.be/mathias/gitea-mcp/internal/allowlist"
|
|
"gitea.d-ma.be/mathias/gitea-mcp/internal/gitea"
|
|
"gitea.d-ma.be/mathias/gitea-mcp/internal/registry"
|
|
)
|
|
|
|
type RepoUpdate struct {
|
|
c *gitea.Client
|
|
a *allowlist.Allowlist
|
|
}
|
|
|
|
func NewRepoUpdate(c *gitea.Client, a *allowlist.Allowlist) *RepoUpdate {
|
|
return &RepoUpdate{c: c, a: a}
|
|
}
|
|
|
|
func (t *RepoUpdate) Descriptor() registry.ToolDescriptor {
|
|
return registry.ToolDescriptor{
|
|
Name: "repo_update",
|
|
Description: "Update repository metadata (description, visibility, default branch, website, archived, template). " +
|
|
"Only fields explicitly set in the call are patched. " +
|
|
"WARNING: private=false exposes the repo publicly — verify intent before calling.",
|
|
InputSchema: json.RawMessage(`{
|
|
"type":"object",
|
|
"properties":{
|
|
"owner":{"type":"string"},
|
|
"repo":{"type":"string"},
|
|
"description":{"type":"string"},
|
|
"private":{"type":"boolean","description":"Toggle visibility. false makes the repo public."},
|
|
"website":{"type":"string","description":"Homepage URL"},
|
|
"default_branch":{"type":"string","description":"Rename the default branch"},
|
|
"archived":{"type":"boolean","description":"Mark repo as archived (read-only)."},
|
|
"template":{"type":"boolean","description":"Toggle template-repo flag"},
|
|
"confirm":{"type":"string","description":"Required when setting private=false. Must equal the repo name."}
|
|
},
|
|
"required":["owner","repo"]
|
|
}`),
|
|
}
|
|
}
|
|
|
|
type repoUpdateArgs struct {
|
|
Owner string `json:"owner"`
|
|
Repo string `json:"repo"`
|
|
Description *string `json:"description,omitempty"`
|
|
Private *bool `json:"private,omitempty"`
|
|
Website *string `json:"website,omitempty"`
|
|
DefaultBranch *string `json:"default_branch,omitempty"`
|
|
Archived *bool `json:"archived,omitempty"`
|
|
Template *bool `json:"template,omitempty"`
|
|
Confirm string `json:"confirm"`
|
|
}
|
|
|
|
func (t *RepoUpdate) Call(ctx context.Context, raw json.RawMessage) (json.RawMessage, error) {
|
|
var args repoUpdateArgs
|
|
if err := parseArgs(raw, &args); err != nil {
|
|
return nil, err
|
|
}
|
|
if err := t.a.Check(args.Owner); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Making a repo public is a significant action — require explicit confirmation.
|
|
if args.Private != nil && !*args.Private {
|
|
if args.Confirm != args.Repo {
|
|
return nil, fmt.Errorf("setting private=false makes the repo public: set confirm=%q to proceed", args.Repo)
|
|
}
|
|
}
|
|
|
|
if args.Description == nil && args.Private == nil && args.Website == nil &&
|
|
args.DefaultBranch == nil && args.Archived == nil && args.Template == nil {
|
|
return nil, fmt.Errorf("at least one updatable field must be set: %w", gitea.ErrValidation)
|
|
}
|
|
|
|
r, err := t.c.UpdateRepo(ctx, args.Owner, args.Repo, gitea.UpdateRepoArgs{
|
|
Description: args.Description,
|
|
Private: args.Private,
|
|
Website: args.Website,
|
|
DefaultBranch: args.DefaultBranch,
|
|
Archived: args.Archived,
|
|
Template: args.Template,
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return textOK(r)
|
|
}
|