7 Commits

Include renames

Author	SHA1	Message	Date
mathiasandClaude Opus 5.5	1cf05fdf15	test(search): in-brain Query race queries the inside note too ... After main's #177 floor (AssertNoLeakFrom needs at least one read that returns the inside note), this test went red on merge: the reader queried only the sentinel, so the regular note could never be a hit and the race had been passing vacuously. Query both terms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 16:20:41 +02:00
mathias	51183d64d8	Merge remote-tracking branch 'origin/main' into merge-check	2026-10-05 16:17:54 +02:00
mathiasandClaude Opus 5.5	0bd0fbf03e	test(brainfstest): swap-race asserts fail when nothing was tested ... AssertNoLeakFrom and the search Query race test passed vacuously when every symlink swap failed or every read errored. Both now count successful symlink swaps and reads that returned the inside note and fail if either is zero; the Query race reader no longer swallows Query's error. Verified by flipping: a swapper whose os.Symlink always fails turns notes, wiki and search race tests red; Query on a missing brain dir turns the search race test red. Closes #177 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 09:32:25 +02:00
mathiasandClaude Opus 5.5	a83f0cb381	test(search): name the in-brain swap-race tests after what they sample ... Review of #172 (rule 9): "LeaksNothing" claims more than a 1.5s sampled race can prove -- the same overclaim this PR removes from the "Never" names. Renamed to DoesNotReturn...DuringASampledSwapRace, and the brainfstest doc now says the target may be inside the brain (#171) and that observation is over a sampled window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 07:19:27 +02:00
mathiasandClaude Opus 5.5	bf3646c0c7	test(brainfs): per-caller in-brain symlink targets for slices 1-3 (#171) ... os.Root refuses links that leave the brain on its own, so the slice 1-3 callers' outside-target tests stayed green when a caller read without brainfs's Lstat/SameFile checks (PR #168 round-2 review). Adds a static in-brain link (wiki/w/facts/inlink.md -> ../../../raw/s.md) and an AssertNoLeakFrom swap race with an in-brain target for search.Query, hydrate, vectorstore.Sync, readExcerpt and api.ReadNote. Flip-verified: replacing each caller's bfs.ReadRegular with an os.OpenRoot(brainDir).ReadFile turns every one red on the new assertions (Query, hydrate, Sync, readExcerpt, ReadNote). Also from that review: rename TestReadRegularNever... to ...DoesNotReturn... (rule 9: a sampled race), and AssertNoLeakFrom's failure message names the symlink target instead of 'outside file'. Closes #171 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 07:02:41 +02:00
mathiasandClaude Opus 5.5	57d0fb0fae	fix(vectorstore): walk and read the brain through brainfs (#157, slice 3) (#166) ... vectorstore.Sync walks and reads via brainfs (regular files only, handle-checked), so symlinked notes are no longer embedded and their old chunks are purged. brainfs.WalkRegular requires every component of its root to be a real directory (fixes in-brain root aliasing in Sync and search Wing/Wing+Hall). Walk errors, including a symlinked scan root, abort Sync before the delete pass. brainfs gains Lstat. Directory-swap race recorded as accepted residual (#167). Refs #157. Adversarial review: BLOCKED, BLOCKED, PASS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Mathias <mthbqv@gmail.com>	2026-10-04 06:35:17 +00:00
mathias	eb77305580	fix(search): walk and read the brain through an os.Root (#157, slice 1) (#161) ... Co-authored-by: Mathias <mthbqv@gmail.com>	2026-10-03 19:34:46 +00:00