chore(brain): remove brain_write legacy params domain/type/knowledge-path (ADR-0012) #131
2
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
  mathiasandClaude Sonnet 5
|
975b61c9d7 |
fix: hyperguild brain write requires wing/hall, not legacy type/slug
PR #131 removed WriteNote's legacy brain/knowledge/ fallback branch that activated when wing/hall were both empty, but never updated the CLI that was the only caller relying on it. Since `hyperguild brain write` never sent wing/hall, every invocation of the CLI's most load-bearing brain command started hard-erroring "wing and hall are required" — a live, README-documented command broken on every call. Separately, writeRequest never had a `slug` field (pre-existing, unrelated to #131): the CLI's slug value was silently dropped server-side even before this PR, falling back to a timestamp filename. Fix: - `hyperguild brain write <wing> <hall> <slug>` replaces the old `<type> <slug>` shape. Positional args, mirroring the existing `brain query <topic>` pattern and matching writeHallNote's own wing/hall/slug parameter order server-side (handler.go's brain.NotePath(brainDir, wing, hall, slug)) — no new flags needed since wing/hall/slug are all required, not optional filters. - brainClient.Write now sends {wing, hall, filename, content}, matching writeRequest exactly (writeRequest already gained a Filename field in #131, so no server-side change was needed — only the CLI was sending the wrong shape). This also fixes the dead slug bug: slug now arrives server-side as filename instead of being silently dropped. - Added TestWrite_CLIPayloadRoundTrips in ingestion/internal/api, which POSTs the CLI's exact JSON envelope to the real Handler.Write (not a mock) and asserts a real file with real wing/hall frontmatter lands on disk. cmd/hyperguild and ingestion are separate Go modules (no go.work), so this can't be a single cross-module test — instead the wire contract is pinned from the server side, closing the gap where cmd/hyperguild/http_test.go's TestBrainClient_Write_Success used only a hand-rolled httptest mock and stayed green through the wing/hall regression. - Updated cmd/hyperguild/README.md and the 2026-05-03 CLI design spec's stale `<type> <slug>` examples. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> |
||
|
mathiasandClaude Sonnet 5
|
e8e233823d |
chore(brain): remove brain_write legacy params domain/type/knowledge-path (ADR-0012)
hyperguild#79's caller audit (done in a prior session) found the removal was safe: - The promote/pending flow (#38/#81, ingestion/internal/api/promote.go) operates exclusively on brainDir/raw/ -> brainDir/wiki/<wing>/<hall>/. It never touches brainDir/knowledge/, so removing the knowledge/ write path does not break it. - No live caller uses domain/type or the knowledge/ path: checked hyperguild itself, mathias/skills, mathias/agentsquad, mathias/dispatch, mathias/cad, mathias/cad-atlas. - internal/skills/brain (a skill.go + handlers.go pair) defined a third, even-more-legacy brain_write shape (type/domain/filename, no wing/hall) for an old "supervisor" MCP server whose cmd/supervisor/main.go no longer exists. Nothing outside its own test imported it; deleted entirely as it encodes the exact legacy shape this issue removes. Changes: - ingestion/internal/mcp/handlers.go: brain_write's tool schema and brainWriteArgs drop type/domain; wing+hall are now marked required in the schema. - ingestion/internal/api/handler.go: WriteNote has one behaviour — wing+ hall required, routing to wiki/<wing>/<hall>/. writeLegacyNote and the knowledge/-path branch are deleted. Omitting wing or hall now returns "wing and hall are required" (400 over HTTP, a tool error over MCP) — the only sane failure mode left once there is no other valid destination. - ingestion/internal/capture/ports.go, internal/brainstore/store.go: drop Type/Domain from capture.Note and its WriteNoteOptions construction. pipeline/*.go's unrelated "domain" field (a different, legitimate concept for brain_ingest_raw) is untouched. - internal/skills/brain/: deleted (orphaned legacy tool schema, dead since cmd/supervisor was removed). Tests: added TestWriteNote_RequiresWingAndHall (api), TestBrainWriteRequiresWingAndHall + TestBrainWriteIgnoresLegacyTypeAndDomainParams (mcp) for the new single behaviour; removed tests that only exercised the deleted legacy path (TestWrite_IncludesFrontmatterWhenTypeProvided, TestWriteNote_HallRouteExistingTypeWinsOverOptsType, TestBrainWriteRejectsTraversal, TestBrainWriteAcceptsDoubleDotInName — the latter two's filename-sanitisation behaviour is covered independently by internal/brain/path_test.go's TestNotePath_SanitisesWingAndSlug / TestSanitise, which is unaffected by this change). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> |