fix(search): walk and read the brain through an os.Root (#157, slice 1) #161

Merged

mathias merged 3 commits from fix/search-root-157 into main 2026-10-03 19:34:46 +00:00

Conversation 3 Commits 3 Files Changed 4

+382 -10

3 Commits

Author	SHA1	Message	Date
mathiasandClaude Opus 5.5	fd33e04467	test(search): hold a writer on swapped-in FIFOs; await the swapper ... PR #161 round 2: ReadRegular bypassing readOpened (non-blocking open, no handle check) stayed green, because the search FIFO race used FIFOs with no writer, which read EOF at once. The swapper now opens each FIFO O_RDWR and keeps every writer open until it exits, as any local process could, so a reader that skips the handle check parks forever; the bypass flip is red. The swapper is stopped and awaited in a t.Cleanup before t.TempDir removal (hyperguild#162). Refs #157 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-03 18:32:40 +02:00
mathiasandClaude Opus 5.5	ffe46c7077	test(brainfs): pin the handle check with a FIFO held open by a writer ... PR #161 review: removing ReadRegular's type check on the opened handle stayed green, because the race test's FIFOs had no writer and read EOF at once; with a writer holding the FIFO open, search hung after 16 iterations. The open-and-check step is split into readOpened, and TestReadOpenedRefusesAFIFOHeldOpenByAWriter reaches it past the Lstat with a writer open: it must return ErrNotRegular promptly (the flip is red). Also unit tests for ReadRegular (symlink, escape), Rel (inside incl. ..foo, escapes) and WalkRegular (regular files only), and the hard-link residual documented where it is accepted, as in api/rawroot.go. Refs #157 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-03 18:26:27 +02:00
mathiasandClaude Opus 5.5	9c9ba31770	fix(search): walk and read the brain through an os.Root (#157, slice 1) ... Option 1 of #157, first slice. Search walked and read the brain by path, so a symlink planted in the Syncthing-shared brain dir put an outside file's contents in brain_query results, and a FIFO swapped into the wiki hung the query forever (reproduced: the FIFO race test blocked for the full 6s timeout before this change). New package internal/brainfs: Open (os.Root on the brain dir), ReadRegular (Lstat + non-blocking open + type check on the handle) and WalkRegular (walks the root's FS, yields regular files only, never follows a link). search.Query and hydrate use it. Tests (red first): a wiki symlink is not followed, a symlinked dir is not descended, hydrate refuses a symlink, and race tests swap a symlink or a FIFO into a wiki note while Query loops; any leaked byte or a hang fails. Refs #157 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-03 18:18:54 +02:00