fix: creating and generated writes go through the brain root (#188, #158 part A) #189

Merged

mathias merged 4 commits from fix/create-regular-188 into main 2026-10-05 21:25:54 +00:00

Conversation 3 Commits 4 Files Changed 15

+645 -82

4 Commits

Author	SHA1	Message	Date
mathiasandClaude Opus 5.5	ac84ddf5a9	test: pin CreateRegular directly and promote/reject with in-brain targets (#188) ... Review round 2 on PR #189: CreateRegular (promote's and reject's only write path) had no test; replacing mkdirReal with root.MkdirAll, dropping cleanRel or calling PutRegular all stayed green, and the promote/reject test planted only outside targets, which os.Root refuses on its own. - TestCreateRegularCreatesOnlyNewFilesThroughRealDirectories: in-brain symlinked parent, unclean path, existing file and dangling link (fs.ErrExist, nothing changed), positive control with missing parents. - TestPromoteAndRejectRefuseAnInBrainSymlinkedDestinationDirectory. All three flips are red now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 23:19:02 +02:00
mathiasandClaude Opus 5.5	db18785bfc	test: pin the edit symlink refusal, AppendRegular's clean check and Remove (#188) ... Review round 1 on PR #189 (three tests stayed green with their guard removed): - TestEditRefusesANoteBehindASymlinkedDirectory had no .git, so Edit refused "not the sync source" before any path check. It now has one, plus a positive control. - AppendRegular's unclean-path case was refused by a final symlink, not cleanRel. New test where ".." after a symlinked dir resolves to a real file, for AppendRegular and PutRegular. - brainfs.Remove had no test; new one (refuses behind a symlinked dir, removes a final link but never its target, positive control). Also: promote/reject create with O_EXCL (new brainfs.CreateRegular), so a note that appears after the collision check is never overwritten; gofmt fixes in provenance.go and wiki/log.go; dead wingDir and putBrainFile removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 22:57:26 +02:00
mathiasandClaude Opus 5.5	138d6e2545	fix: generated and promoted writes go through the brain root (#188, #158) ... Writers that created or rewrote brain files by path followed symlinks: - promote/reject: os.MkdirAll + os.WriteFile of the destination, then os.Remove of the raw source. Now PutRegular + brainfs.Remove; the source is kept when the write is refused. - StampProvenanceFile (brain_edit's re-stamp): provenance.ApplyFile read and rewrote by path. Now ReadRegular + WriteRegular; ApplyFile, now unused, is removed. - BuildWingIndex (_index.md) and wiki.RebuildIndex (wiki/index.md): now PutRegular. - wiki.AppendLog (log.md) and AutoTunnel's fuzzy-candidate log (raw/tunnel-candidates-*.md): now AppendRegular; tunnel's fileExists, now unused, is removed. - New brainfs.Remove: clean path, real parent, removes a final symlink itself, never its target. brain_edit's own atomic rename was already refused behind a symlinked directory by #187's read check; a guard test pins it. Pipeline writes, BackfillRefs, the watcher's raw/ markers and the session archive in cmd/server follow in a separate PR (#158). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 22:39:41 +02:00
mathiasandClaude Opus 5.5	41b7105b31	fix(brainfs,api): PutRegular/AppendRegular; brain_write creates through the brain root (#188) ... brain_write created a new note with os.MkdirAll + os.WriteFile by path, so a symlinked wing or hall directory redirected the note elsewhere in the brain or outside it. New brainfs primitives for creating writes: - PutRegular: create or replace. Missing parents are created one component at a time through the root and every existing component must be a real directory; an existing file is replaced only via WriteRegular's checks; a new one is created with O_EXCL and confirmed (Lstat + SameFile) before writing. - AppendRegular: create-or-append with the same parent rule, writing only after confirming the path is the regular file it opened. - RealParent: the clean-path + real-directory check, for writers that do their own atomic rename. writeHallNote now uses PutRegular. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 22:35:19 +02:00