mathiasandClaude Sonnet 5.5
1025d77795
From the independent review of #210: - F1: processed/ and failed/ copies are created O_EXCL with -2,-3 suffixes via createUnique; same-named notes from different folders no longer replace one another's only surviving copy - F2: extract.TextInMax / readAllMax cap the bytes actually read (a note can grow after the Lstat); extract.TextIn gets a 64 MiB default cap - F3: a regular marker older than its note describes an earlier note of the same name; it no longer hides the new one (warn + remove); non-regular markers still count as done (no writes through links) - F4: the planted-marker-link test is renamed to what it observes Each has a test that fails without it; the read-cap test uses an endless reader that errors at 8 MiB so a regression fails instead of exhausting memory. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
52 lines
1.6 KiB
Go
52 lines
1.6 KiB
Go
package watcher
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"io/fs"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"github.com/mathiasbq/hyperguild/ingestion/internal/brainfs"
|
|
)
|
|
|
|
// Kept out of watcher.go on purpose: that file is covered by the raw-reader
|
|
// guard (internal/extract/callsites_test.go), which forbids any .Open selector
|
|
// there. This function reads nothing from raw/; it creates a file under the
|
|
// brain root, which refuses symlinked directories and never follows a final
|
|
// symlink.
|
|
|
|
// createParked writes data to raw/needs-review/<filename> through the brain
|
|
// root, never replacing a parked note: on a name clash it tries -2, -3, ...
|
|
// A needs-review that is a symlink, or any non-directory, is refused.
|
|
func createParked(brainDir, filename string, data []byte) error {
|
|
return createUnique(brainDir, "raw/needs-review", filename, data)
|
|
}
|
|
|
|
// createUnique writes data to dirRel/filename through the brain root, never
|
|
// replacing an existing file: on a name clash it tries -2, -3, ... A dirRel that
|
|
// is a symlink, or any non-directory, is refused.
|
|
func createUnique(brainDir, dirRel, filename string, data []byte) error {
|
|
bfs, err := brainfs.Open(brainDir)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer func() { _ = bfs.Close() }()
|
|
ext := filepath.Ext(filename)
|
|
stem := strings.TrimSuffix(filename, ext)
|
|
for n := 1; n < 10000; n++ {
|
|
name := filename
|
|
if n > 1 {
|
|
name = fmt.Sprintf("%s-%d%s", stem, n, ext)
|
|
}
|
|
err := bfs.CreateRegular(dirRel+"/"+name, data)
|
|
if err == nil {
|
|
return nil
|
|
}
|
|
if !errors.Is(err, fs.ErrExist) {
|
|
return err
|
|
}
|
|
}
|
|
return fmt.Errorf("no free name for %q in %s", filename, dirRel)
|
|
}
|