Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
e12ac99465 | ||
|
|
dc97fd4a36 |
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "skills",
|
"name": "skills",
|
||||||
"description": "Mathias's engineering skills library, plus the hooks and MCP servers that make it enforceable: TDD, clean code, debugging, specs, discovery, CI, and secret hygiene.",
|
"description": "Mathias's engineering skills library, plus the hooks and MCP servers that make it enforceable: TDD, clean code, debugging, specs, discovery, CI, and secret hygiene.",
|
||||||
"version": "0.10.0",
|
"version": "0.10.1",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Mathias",
|
"name": "Mathias",
|
||||||
"url": "https://git.d-ma.be/mathias"
|
"url": "https://git.d-ma.be/mathias"
|
||||||
|
|||||||
@@ -14,6 +14,8 @@ Code review is smell detection and principle verification, not style policing. T
|
|||||||
|
|
||||||
**This skill is read-only analysis.** When you find issues, document them with specific file:line references and prioritize by architectural impact. For fixes, load the `refactoring` or `clean-code` skill.
|
**This skill is read-only analysis.** When you find issues, document them with specific file:line references and prioritize by architectural impact. For fixes, load the `refactoring` or `clean-code` skill.
|
||||||
|
|
||||||
|
Three similarly-named skills cover orthogonal concerns, and landing on one is no reason to miss the others: this one is **what to check**, `superpowers-requesting-code-review` is **how to commission a reviewer**, and `superpowers-receiving-code-review` is **how to behave when the feedback arrives**.
|
||||||
|
|
||||||
## When to Use
|
## When to Use
|
||||||
|
|
||||||
- Pre-merge review of any pull request
|
- Pre-merge review of any pull request
|
||||||
|
|||||||
@@ -74,6 +74,9 @@ legal waived"), never silently dropped. Silent omission is the most common way a
|
|||||||
3. Mark every discipline: cleared / waived (with reason) / gap.
|
3. Mark every discipline: cleared / waived (with reason) / gap.
|
||||||
4. If any gap is on a discipline that gates the whole bet, **do not bring the ask** — close
|
4. If any gap is on a discipline that gates the whole bet, **do not bring the ask** — close
|
||||||
the gap or bring a feedback-only ask instead.
|
the gap or bring a feedback-only ask instead.
|
||||||
|
5. Load `grill-me` (Full Grill) on the ask before bringing it. A council's hard questions are
|
||||||
|
cheaper to answer in private first, and a gap found by grilling is a gap you close rather
|
||||||
|
than one the gate reports.
|
||||||
|
|
||||||
**Chairing a review (you are the council):**
|
**Chairing a review (you are the council):**
|
||||||
1. Ask for the evidence behind each "cleared", not the claim. Claims are theatre.
|
1. Ask for the evidence behind each "cleared", not the claim. Claims are theatre.
|
||||||
|
|||||||
@@ -14,6 +14,8 @@ Code review requires technical evaluation, not emotional performance.
|
|||||||
|
|
||||||
**Core principle:** Verify before implementing. Ask before assuming. Technical correctness over social comfort.
|
**Core principle:** Verify before implementing. Ask before assuming. Technical correctness over social comfort.
|
||||||
|
|
||||||
|
This skill starts where `superpowers-requesting-code-review` ends. The substance of what a reviewer should have checked is `code-review`.
|
||||||
|
|
||||||
## The Response Pattern
|
## The Response Pattern
|
||||||
|
|
||||||
```
|
```
|
||||||
@@ -30,7 +32,7 @@ WHEN receiving code review feedback:
|
|||||||
## Forbidden Responses
|
## Forbidden Responses
|
||||||
|
|
||||||
**NEVER:**
|
**NEVER:**
|
||||||
- "You're absolutely right!" (explicit CLAUDE.md violation)
|
- "You're absolutely right!" (performative agreement, not evaluation)
|
||||||
- "Great point!" / "Excellent feedback!" (performative)
|
- "Great point!" / "Excellent feedback!" (performative)
|
||||||
- "Let me implement that now" (before verification)
|
- "Let me implement that now" (before verification)
|
||||||
|
|
||||||
|
|||||||
@@ -12,6 +12,8 @@ Dispatch a code reviewer subagent to catch issues before they cascade. The revie
|
|||||||
|
|
||||||
**Core principle:** Review early, review often.
|
**Core principle:** Review early, review often.
|
||||||
|
|
||||||
|
This skill is the *commissioning* half. What the reviewer should look for is `code-review`; how to handle what comes back is `superpowers-receiving-code-review`.
|
||||||
|
|
||||||
## When to Request Review
|
## When to Request Review
|
||||||
|
|
||||||
**Mandatory:**
|
**Mandatory:**
|
||||||
|
|||||||
Reference in New Issue
Block a user