mathias
4a2067063d
Upload a recording (audio, or video with the camera off), get a private Swedish transcript, and chat about it. - ADR-033: RLS-scoped private transcript store; ffprobe/ffmpeg intake; gateway transcription (iguana kb-whisper, berget fallback); in-process single-replica worker; chat over the transcript (local models only). - ADR-034: optional two-engine mode (pianissimo + kb-whisper) reconciled by a LOCAL model; off unless TAPIR_RECONCILE_BASE_MODEL is set. - ADR-035: real progress (phases, running/quiet/lost), phase logging, every judged spot stored, merged segments. - Hardening from four adversarial reviews: errors logged and stored as kinds never text; per-engine deadlines; converted-length check; bounded queue; client hang-ups are not errors; strict local-alias check. - Dockerfile: static ffmpeg/ffprobe 7.0.2 pinned by sha256 (#34). Built and inspected by hand; CI does not build the image on a PR, so its first CI build is this merge. Uploads stay OFF until TAPIR_UPLOADS_ENABLED is set in the deployment. Closes #33, #34, #42, #43, #44. Co-authored-by: Mathias <mthbqv@gmail.com>
74 lines
2.8 KiB
Go
74 lines
2.8 KiB
Go
package web_test
|
|
|
|
import (
|
|
"net/http"
|
|
"net/url"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"git.d-ma.be/mathias/tapir/internal/adapters/chat"
|
|
"git.d-ma.be/mathias/tapir/internal/web"
|
|
)
|
|
|
|
// The whole private transcript goes to the model chosen in the form, so the upload chat
|
|
// offers and accepts local models only, even when the shared chat service knows a cloud
|
|
// one (ADR-035 review). The cloud model here is only a name; no network is involved.
|
|
|
|
func newUploadChatAppWithCloud(t *testing.T) (*web.App, *fakeChatter) {
|
|
t.Helper()
|
|
app, _ := newUploadApp(t, audioOK, 200<<20)
|
|
fc := &fakeChatter{
|
|
models: []string{"koala/phi4-mini", "iguana/gemma4-26b", "berget/mistral-small"},
|
|
reply: chat.Reply{Answer: "Anders owns the timber order."},
|
|
}
|
|
app.Chat = fc
|
|
app.UploadChatMaxChars = 120000
|
|
app.UploadChatModels = []string{"koala/phi4-mini", "iguana/gemma4-26b"}
|
|
return app, fc
|
|
}
|
|
|
|
func TestUploadChatPage_DoesNotOfferACloudModelEvenThoughTheServiceKnowsOne(t *testing.T) {
|
|
app, _ := newUploadChatAppWithCloud(t)
|
|
id := seedUpload(t, userID, "Roadmap sync", "done", meetingText)
|
|
|
|
b := body(t, do(t, app, get("/uploads/"+id+"/chat")))
|
|
|
|
assert.Contains(t, b, "iguana/gemma4-26b")
|
|
assert.NotContains(t, b, "berget/mistral-small", "the switcher must not list a model the transcript must not be sent to")
|
|
}
|
|
|
|
func TestUploadChatPost_AForgedCloudModelIsReplacedByALocalOneBeforeTheTranscriptIsSent(t *testing.T) {
|
|
app, fc := newUploadChatAppWithCloud(t)
|
|
id := seedUpload(t, userID, "Roadmap sync", "done", meetingText)
|
|
|
|
rec := do(t, app, chatPost("/uploads/"+id+"/chat", url.Values{"question": {"Who owns timber?"}, "model": {"berget/mistral-small"}}))
|
|
|
|
require.Equal(t, http.StatusOK, rec.Code)
|
|
require.Equal(t, 1, fc.callCount)
|
|
assert.NotEqual(t, "berget/mistral-small", fc.gotReq.Model, "a cloud model reached the chat service with the private transcript")
|
|
assert.Contains(t, []string{"koala/phi4-mini", "iguana/gemma4-26b"}, fc.gotReq.Model)
|
|
}
|
|
|
|
func TestUploadChatPost_ALocalModelThatIsOfferedIsHonoured(t *testing.T) {
|
|
app, fc := newUploadChatAppWithCloud(t)
|
|
id := seedUpload(t, userID, "Roadmap sync", "done", meetingText)
|
|
|
|
rec := do(t, app, chatPost("/uploads/"+id+"/chat", url.Values{"question": {"q"}, "model": {"koala/phi4-mini"}}))
|
|
|
|
require.Equal(t, http.StatusOK, rec.Code)
|
|
assert.Equal(t, "koala/phi4-mini", fc.gotReq.Model)
|
|
}
|
|
|
|
func TestUploadChat_WithNoLocalModelConfiguredNothingIsSentAnywhere(t *testing.T) {
|
|
app, fc := newUploadChatAppWithCloud(t)
|
|
app.UploadChatModels = nil
|
|
id := seedUpload(t, userID, "Roadmap sync", "done", meetingText)
|
|
|
|
rec := do(t, app, chatPost("/uploads/"+id+"/chat", url.Values{"question": {"q"}, "model": {"berget/mistral-small"}}))
|
|
|
|
require.Equal(t, http.StatusOK, rec.Code)
|
|
assert.Zero(t, fc.callCount, "failing closed: no local model offered means no model is called")
|
|
}
|