fix: green baseline, and let the template test itself #13

Merged

mathias merged 3 commits from fix/green-baseline-and-self-test into main 2026-09-17 16:16:38 +00:00

Conversation 1 Commits 3 Files Changed 6

+144 -6

3 Commits

Author	SHA1	Message	Date
mathiasandClaude Opus 5	2c4158a808	fix(test): grade golangci-lint on its exit code, not on grepping its output ... Addresses the blocking finding from the review of this PR. The harness matched golangci-lint's human-readable summary to decide pass or fail, and discarded its exit status. Any failure that is not "found issues" -- bad config, unwritable TMPDIR, OOM, a future change to the output format -- produces non-matching text and was scored `ok`. Since this harness is the only gate covering cmd/__PROJECT_NAME__, a linter that dies would have left the entrypoint unchecked with CI green. That is the precise defect class this file was added to end, which is why it blocked the PR rather than being filed as a follow-up. golangci-lint exits 0 clean / 1 issues found / >1 the linter itself failed. Now graded on that, and the >1 case reports the child as UNCHECKED rather than clean. Two more from the same review: - a missing tool now fails instead of `exit 0` with zero assertions, which was indistinguishable from a real pass to anything reading the exit code. It was unreachable in CI only by luck of task ordering, not by rule. - Dockerfile joins the substituted file set. It builds ./cmd/__PROJECT_NAME__ and was outside the pattern, so the harness never validated the one path a repo rename has historically broken here. Verified by flipping each case: crashing linter (exit 3) -> FAIL "the child is UNCHECKED, not clean" tools absent -> FAIL, 0 passed normal -> 5 passed, 0 failed Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-09-17 18:14:23 +02:00
mathiasandClaude Opus 5	39b8e86540	fix(ci): let the template test itself, and cover the entrypoint ./... cannot see ... Closes #12. The guard that stops this template building itself also stopped it TESTING itself: check, build and deploy were all gated on is_template, which is always true here. So the repo that mints every other repo was the one repo with no working gate — and #8 sat in it for months with CI green throughout, found eventually by a child rather than by us. check is now ungated. build and deploy stay gated, because they genuinely cannot work here: placeholder module path, no image name, no namespace. Ungating alone would have been a false fix. `go build ./...`, `go vet ./...`, `go test ./...` and `golangci-lint run ./...` cannot see cmd/__PROJECT_NAME__ at all — Go skips directories whose names begin with an underscore when expanding package patterns: $ go list ./... __MODULE_PATH__/internal/web <- no cmd package So a newly-ungated check would still have skipped the package every generated repo is built around. scripts/tests/generated-child_test.sh substitutes the tracked tree into a throwaway child and gates the result: templ generate, go list, build, vet, golangci-lint. Ported from template-go-agent, plus a templ step, which also proves the pinned generator and pinned library agree. Proven to fail when it should. With a deliberate errcheck violation added to the entrypoint: generated-child harness -> FAIL cmd/childproj/main.go:12:26 errcheck golangci-lint run ./... -> "0 issues." The existing gate calls the same broken code clean. That contrast is the reason this harness exists rather than a wider lint invocation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-09-17 18:05:23 +02:00
mathiasandClaude Opus 5	b40db025cc	fix(template): ship a go.sum, and stop the templ generator drifting from the library ... Closes #8. `task check` did not pass on a clean checkout of this template, and had not for some time. Three defects in a chain, each hiding the next: 1. No go.sum at all. `go build ./...` failed on missing sum entries, so nothing downstream of it ever ran. 2. With that fixed, the real skew appeared: CI installs the templ GENERATOR as @latest while go.mod pinned the templ LIBRARY at v0.2.778. The v0.3 generator emits calls to templruntime.WriteString, which v0.2.778 does not have -- so generated code could not compile against the pinned runtime. Library moved to v0.3.1020 and the CI install now derives its version from go.mod, so generator and library cannot drift apart again. 3. .gitignore carried `*.templ.go`. templ writes `<name>_templ.go` -- an underscore, not a dot -- so the pattern matched nothing. Generated files were kept out of git by luck rather than by the ignore rule. None of this was visible from this repo's CI, which has been green throughout, because the guard job skips `check` here entirely (#12). A template whose gate cannot run is a template whose defects are found by its children. Verified on a clean checkout: `go build ./...` clean, `task check` exit 0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-09-17 18:04:13 +02:00