scripts/tests/generated-child_test.sh

@@ -34,10 +34,13 @@ bad() { printf '  FAIL %s\n     %s\n' "$1" "${2:-}"; fail=$((fail+1)); }
 
 echo "generated-child tests"
 
+# A missing tool is a FAILURE, not a skip. An `exit 0` with zero assertions is
+# indistinguishable from a real pass to anything reading the exit code -- which
+# is the whole failure mode this harness exists to close.
 for tool in golangci-lint templ; do
   if ! command -v "$tool" >/dev/null 2>&1; then
-    echo "  SKIP $tool not installed — cannot gate the generated child" >&2
+    bad "$tool is available" "not on PATH — the generated child cannot be gated"
-    exit 0
+    echo; echo "$pass passed, $fail failed"; exit 1
   fi
 done
 
@@ -58,7 +61,7 @@ if [ ! -d "$tmp/cmd/__PROJECT_NAME__" ]; then
   echo; echo "$pass passed, $fail failed"; exit 1
 fi
 mv "$tmp/cmd/__PROJECT_NAME__" "$tmp/cmd/childproj"
-find "$tmp" -type f \( -name '*.go' -o -name '*.templ' -o -name '*.mod' -o -name '*.yml' -o -name '*.md' \) \
+find "$tmp" -type f \( -name '*.go' -o -name '*.templ' -o -name '*.mod' -o -name '*.yml' -o -name '*.md' -o -name 'Dockerfile' \) \
   -exec sed -i \
     -e 's|__MODULE_PATH__|git.d-ma.be/mathias/childproj|g' \
     -e 's|__PROJECT_NAME__|childproj|g' {} +
@@ -66,11 +69,11 @@ find "$tmp" -type f \( -name '*.go' -o -name '*.templ' -o -name '*.mod' -o -name
 # Generated files are gitignored, so the child arrives without them — exactly as
 # a freshly scaffolded repo does. Generating here also proves the pinned
 # generator and the pinned library agree, which is template-go-web#8.
-out="$(cd "$tmp" && templ generate 2>&1)"
+out="$(cd "$tmp" && templ generate 2>&1)"; rc=$?
-if [ $? -eq 0 ]; then
+if [ "$rc" -eq 0 ]; then
   ok "templ generate succeeds in the generated child"
 else
-  bad "templ generate succeeds in the generated child" "$(printf '%s' "$out" | tail -3)"
+  bad "templ generate succeeds in the generated child" "exit $rc: $(printf '%s' "$out" | tail -2)"
 fi
 
 # The whole point: the entrypoint must be visible to Go tooling in the child.
@@ -90,12 +93,21 @@ out="$(cd "$tmp" && go vet ./... 2>&1)"
 [ -z "$out" ] && ok "the generated child passes go vet" \
               || bad "the generated child passes go vet" "$(printf '%s' "$out" | head -3)"
 
-out="$(cd "$tmp" && golangci-lint run ./... 2>&1)"
+# Graded on the EXIT CODE, never on grepping the output. golangci-lint exits
-if printf '%s' "$out" | grep -qE '^[0-9]+ issues:|issues:$'; then
+# 0 clean / 1 issues found / >1 the linter itself failed. Matching its
-  bad "the generated child passes golangci-lint" "$(printf '%s' "$out" | grep -E '\.go:[0-9]+' | head -3)"
+# human-readable summary instead scores a CRASHED linter as a pass -- bad
-else
+# config, unwritable TMPDIR, OOM, or simply a future change to its output
-  ok "the generated child passes golangci-lint"
+# format all produce non-matching text. Since this harness is the only gate
-fi
+# covering the entrypoint, that would leave cmd/__PROJECT_NAME__ unchecked with
+# CI green, which is precisely the defect class this file exists to end.
+out="$(cd "$tmp" && golangci-lint run ./... 2>&1)"; rc=$?
+case "$rc" in
+  0) ok "the generated child passes golangci-lint" ;;
+  1) bad "the generated child passes golangci-lint" \
+         "$(printf '%s' "$out" | grep -E '\.go:[0-9]+' | head -3)" ;;
+  *) bad "golangci-lint ran successfully" \
+         "linter exited $rc — the child is UNCHECKED, not clean: $(printf '%s' "$out" | tail -2)" ;;
+esac
 
 echo
 echo "$pass passed, $fail failed"