test(brainfs): per-caller in-brain symlink targets for slices 1-3 (#171) #172

Merged

mathias merged 5 commits from test/in-brain-targets-171 into main 2026-10-05 19:36:31 +00:00

Conversation 4 Commits 5 Files Changed 7

+109 -7

5 Commits

Author	SHA1	Message	Date
mathiasandClaude Opus 5.5	1cf05fdf15	test(search): in-brain Query race queries the inside note too ... After main's #177 floor (AssertNoLeakFrom needs at least one read that returns the inside note), this test went red on merge: the reader queried only the sentinel, so the regular note could never be a hit and the race had been passing vacuously. Query both terms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 16:20:41 +02:00
mathias	51183d64d8	Merge remote-tracking branch 'origin/main' into merge-check	2026-10-05 16:17:54 +02:00
mathiasandClaude Opus 5.5	f969d97c16	test(notes): in-brain symlink target for ReadScoped, the sixth slice 1-3 caller ... Review of #172 (finding 1): notes.ReadScoped (brain_read, slice 2) had only outside-brain targets, which os.Root refuses on its own, so a reader bypassing brainfs's Lstat/SameFile stayed green. Adds a static in-brain link, a positive control and an in-brain swap race. Flip: replacing ReadRegularMax with os.OpenRoot().ReadFile turns it red 3/3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 07:20:59 +02:00
mathiasandClaude Opus 5.5	a83f0cb381	test(search): name the in-brain swap-race tests after what they sample ... Review of #172 (rule 9): "LeaksNothing" claims more than a 1.5s sampled race can prove -- the same overclaim this PR removes from the "Never" names. Renamed to DoesNotReturn...DuringASampledSwapRace, and the brainfstest doc now says the target may be inside the brain (#171) and that observation is over a sampled window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 07:19:27 +02:00
mathiasandClaude Opus 5.5	bf3646c0c7	test(brainfs): per-caller in-brain symlink targets for slices 1-3 (#171) ... os.Root refuses links that leave the brain on its own, so the slice 1-3 callers' outside-target tests stayed green when a caller read without brainfs's Lstat/SameFile checks (PR #168 round-2 review). Adds a static in-brain link (wiki/w/facts/inlink.md -> ../../../raw/s.md) and an AssertNoLeakFrom swap race with an in-brain target for search.Query, hydrate, vectorstore.Sync, readExcerpt and api.ReadNote. Flip-verified: replacing each caller's bfs.ReadRegular with an os.OpenRoot(brainDir).ReadFile turns every one red on the new assertions (Query, hydrate, Sync, readExcerpt, ReadNote). Also from that review: rename TestReadRegularNever... to ...DoesNotReturn... (rule 9: a sampled race), and AssertNoLeakFrom's failure message names the symlink target instead of 'outside file'. Closes #171 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 07:02:41 +02:00